git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH 4/6] stash: introduce 'git stash store'
Date: Mon, 13 May 2013 23:39:06 +0530	[thread overview]
Message-ID: <CALkWK0nmDopEVArofKt42u5JHRBXmGiHP051jhMxtaihWLu95A@mail.gmail.com> (raw)
In-Reply-To: <7vppwun5zk.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:
> I however suspect that you would regret later when you need more
> customization.  It already happened once for "git merge" when it was
> an internal API for "git pull" and it was painful to support saner
> interface and the traditional one at the same time [*1*].

Oh god.

  git-merge --stat --progress "$merge_name" HEAD 04c5b83c46760573

We made a design mistake at the command-level in merge.  This is at a
subcommand-level.

1. Will git stash store ever be more than a one-liner?  Can you think
of how this function could be larger?

2. Will git stash store ever become an interactive command?  Isn't the
whole point of interactive stash something that operates on a
worktree?  Why will I ever want to operate on a commit with stash,
interactively?

While it is absolutely necessary to avoid calamities like the merge
invocation in git-pull.sh, we shouldn't be over-engineering either.

  reply	other threads:[~2013-05-13 18:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-13 12:45 [PATCH 0/6] Get stash to help rebase.autostash Ramkumar Ramachandra
2013-05-13 12:45 ` [PATCH 1/6] Documentation/stash: correct synopsis for create Ramkumar Ramachandra
2013-05-13 12:45 ` [PATCH 2/6] Documentation/stash: document short form -p in synopsis Ramkumar Ramachandra
2013-05-13 12:45 ` [PATCH 3/6] stash: simplify option parser for create Ramkumar Ramachandra
2013-05-13 14:34   ` Junio C Hamano
2013-05-13 14:59     ` Ramkumar Ramachandra
2013-05-13 12:45 ` [PATCH 4/6] stash: introduce 'git stash store' Ramkumar Ramachandra
2013-05-13 14:40   ` Junio C Hamano
2013-05-13 15:02     ` Ramkumar Ramachandra
2013-05-13 15:49       ` Junio C Hamano
2013-05-13 17:15         ` Ramkumar Ramachandra
2013-05-13 17:29           ` Junio C Hamano
2013-05-13 18:09             ` Ramkumar Ramachandra [this message]
2013-05-13 18:35               ` Junio C Hamano
2013-05-13 18:45                 ` Ramkumar Ramachandra
2013-05-13 19:16                   ` Junio C Hamano
2013-05-13 19:25                     ` Ramkumar Ramachandra
2013-05-13 18:15             ` Ramkumar Ramachandra
2013-05-13 12:45 ` [PATCH 5/6] stash: tweak error message in store_stash () Ramkumar Ramachandra
2013-05-13 14:42   ` Junio C Hamano
2013-05-13 12:45 ` [PATCH 6/6] rebase: use 'git stash store' to simplify logic Ramkumar Ramachandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALkWK0nmDopEVArofKt42u5JHRBXmGiHP051jhMxtaihWLu95A@mail.gmail.com \
    --to=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).