From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: Junio C Hamano <gitster@pobox.com>,
Git List <git@vger.kernel.org>,
Jonathan Nieder <jrnieder@gmail.com>,
Daniel Barkalow <barkalow@iabervon.org>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH 11/18] revert: Save command-line options for continuing operation
Date: Mon, 1 Aug 2011 23:25:37 +0530 [thread overview]
Message-ID: <CALkWK0nprofui1HyewJeCQiX+uRxABAOeFPMGNqQ+jUHtB13GA@mail.gmail.com> (raw)
In-Reply-To: <201107311342.12547.chriscool@tuxfamily.org>
Hi,
Christian Couder writes:
> On Thursday 28 July 2011 18:52:24 Ramkumar Ramachandra wrote:
>> + if (opts->mainline) {
>> + strbuf_reset(&buf);
>
> It is not necessary to reset &buf here.
>
>> + strbuf_addf(&buf, "%d", opts->mainline);
>> + git_config_set_in_file(opts_file, "options.mainline", buf.buf);
>> + }
>
> And perhaps it would be clearer if it was:
>
> + if (opts->mainline) {
> + struct strbuf buf = STRBUF_INIT;
> + strbuf_addf(&buf, "%d", opts->mainline);
> + git_config_set_in_file(opts_file, "options.mainline", buf.buf);
> + strbuf_release(&buf);
> + }
Much clearer. Fixed.
>> + if (opts->strategy)
>> + git_config_set_in_file(opts_file, "options.strategy", opts->strategy);
>> + if (opts->xopts) {
>
> Other nit: maybe you could put "int i" here, instead of at the beginning of
> the function.
Fixed. Thanks.
-- Ram
next prev parent reply other threads:[~2011-08-01 17:56 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 16:52 [PATCH 00/18] Sequencer for inclusion v4 Ramkumar Ramachandra
2011-07-28 16:52 ` [PATCH 01/18] advice: Introduce error_resolve_conflict Ramkumar Ramachandra
2011-07-28 16:52 ` [PATCH 02/18] config: Introduce functions to write non-standard file Ramkumar Ramachandra
2011-07-28 17:35 ` Jonathan Nieder
2011-07-28 20:15 ` Ramkumar Ramachandra
2011-07-28 16:52 ` [PATCH 03/18] revert: Simplify and inline add_message_to_msg Ramkumar Ramachandra
2011-07-28 16:52 ` [PATCH 04/18] revert: Don't check lone argument in get_encoding Ramkumar Ramachandra
2011-07-28 16:52 ` [PATCH 05/18] revert: Rename no_replay to record_origin Ramkumar Ramachandra
2011-07-28 16:52 ` [PATCH 06/18] revert: Eliminate global "commit" variable Ramkumar Ramachandra
2011-07-28 16:52 ` [PATCH 07/18] revert: Introduce struct to keep command-line options Ramkumar Ramachandra
2011-07-28 16:52 ` [PATCH 08/18] revert: Separate cmdline parsing from functional code Ramkumar Ramachandra
2011-07-28 16:52 ` [PATCH 09/18] revert: Don't create invalid replay_opts in parse_args Ramkumar Ramachandra
2011-07-28 16:52 ` [PATCH 10/18] revert: Save data for continuing after conflict resolution Ramkumar Ramachandra
2011-07-28 17:45 ` Jonathan Nieder
2011-07-28 20:18 ` Ramkumar Ramachandra
2011-07-28 16:52 ` [PATCH 11/18] revert: Save command-line options for continuing operation Ramkumar Ramachandra
2011-07-31 11:42 ` Christian Couder
2011-08-01 17:55 ` Ramkumar Ramachandra [this message]
2011-07-28 16:52 ` [PATCH 12/18] revert: Make pick_commits functionally act on a commit list Ramkumar Ramachandra
2011-07-31 12:08 ` Christian Couder
2011-07-31 20:52 ` Christian Couder
2011-08-01 17:23 ` Ramkumar Ramachandra
2011-07-28 16:52 ` [PATCH 13/18] revert: Introduce --reset to remove sequencer state Ramkumar Ramachandra
2011-07-31 14:01 ` Christian Couder
2011-08-01 17:52 ` Ramkumar Ramachandra
2011-07-28 16:52 ` [PATCH 14/18] reset: Make reset remove the " Ramkumar Ramachandra
2011-07-28 16:52 ` [PATCH 15/18] revert: Remove sequencer state when no commits are pending Ramkumar Ramachandra
2011-07-28 16:52 ` [PATCH 16/18] revert: Don't implictly stomp pending sequencer operation Ramkumar Ramachandra
2011-07-28 16:52 ` [PATCH 17/18] revert: Introduce --continue to continue the operation Ramkumar Ramachandra
2011-07-31 15:51 ` Christian Couder
2011-08-01 17:48 ` Ramkumar Ramachandra
2011-08-03 13:34 ` Jonathan Nieder
2011-08-03 17:30 ` Junio C Hamano
2011-08-03 17:59 ` Ramkumar Ramachandra
2011-07-28 16:52 ` [PATCH 18/18] revert: Propogate errors upwards from do_pick_commit Ramkumar Ramachandra
2011-07-28 17:00 ` [PATCH 00/18] Sequencer for inclusion v4 Ramkumar Ramachandra
-- strict thread matches above, loose matches on Subject: below --
2011-08-01 18:06 [PATCH v5 00/18] Sequencer for inclusion Ramkumar Ramachandra
2011-08-01 18:06 ` [PATCH 11/18] revert: Save command-line options for continuing operation Ramkumar Ramachandra
2011-08-04 4:05 ` Christian Couder
2011-08-04 9:25 ` Ramkumar Ramachandra
2011-08-04 10:38 [PATCH 00/18] Sequencer for inclusion v6 Ramkumar Ramachandra
2011-08-04 10:39 ` [PATCH 11/18] revert: Save command-line options for continuing operation Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALkWK0nprofui1HyewJeCQiX+uRxABAOeFPMGNqQ+jUHtB13GA@mail.gmail.com \
--to=artagnon@gmail.com \
--cc=barkalow@iabervon.org \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).