git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "D. Ben Knoble" <ben.knoble@gmail.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>,
	Patrick Steinhardt <ps@pks.im>,
	git@vger.kernel.org
Subject: Re: [GSoC PATCH v2] userdiff: add builtin driver for gitconfig syntax
Date: Mon, 24 Mar 2025 16:23:02 -0400	[thread overview]
Message-ID: <CALnO6CAsF1J39MeO-KY80bQfFL1V3UHT08-Va2R6QNh0JqwZ9A@mail.gmail.com> (raw)
In-Reply-To: <d4c0c9a4-0402-4456-9fa0-3102b5bcc3dc@kdbg.org>

On Mon, Mar 24, 2025 at 3:18 AM Johannes Sixt <j6t@kdbg.org> wrote:
>
>
> You have now managed to avoid the "No newline at end of file", but have
> added a blank line instead. Not a big deal, but unconventional.
>

I missed the opportunity to reply to the original patch on this front,
but here's the information I usually give out:
- VS Code's default settings do not respect POSIX end-of-file newline
standards, so you should probably change them [1]
- There's a similar setting for Intellij IDEA [2] and Vim [3], but
they might have saner defaults (Vim certainly does)
- If your editor or IDE picks up on editorconfig settings, you'll be
able to avoid this
- Git can warn you with diff or show saying "No newline at end of
file," so a careful self-review also catches these.

[1]: https://stackoverflow.com/q/44704968/4400820
[2]: https://stackoverflow.com/q/16761227/4400820
[3]: https://vimhelp.org/options.txt.html#%27endofline%27

-- 
D. Ben Knoble

  reply	other threads:[~2025-03-24 20:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-24  2:11 [GSoC PATCH v2] userdiff: add builtin driver for gitconfig syntax Lucas Seiki Oshiro
2025-03-24  7:18 ` Johannes Sixt
2025-03-24 20:23   ` D. Ben Knoble [this message]
2025-03-25 18:34   ` Lucas Seiki Oshiro
2025-03-24  9:43 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALnO6CAsF1J39MeO-KY80bQfFL1V3UHT08-Va2R6QNh0JqwZ9A@mail.gmail.com \
    --to=ben.knoble@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=j6t@kdbg.org \
    --cc=lucasseikioshiro@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).