From: "D. Ben Knoble" <ben.knoble@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>,
git@vger.kernel.org, ps@pks.im
Subject: Re: [GSoC PATCH v2] revision: remove log_reencode field from rev_info
Date: Fri, 25 Apr 2025 08:51:44 -0400 [thread overview]
Message-ID: <CALnO6CBw0asD2a1iK5UCDX4KXdr1+ua757nt6kEH9fdED2Apvw@mail.gmail.com> (raw)
In-Reply-To: <xmqqcyd33kba.fsf@gitster.g>
On Tue, Apr 22, 2025 at 6:26 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Lucas Seiki Oshiro <lucasseikioshiro@gmail.com> writes:
>
> > Remove the log_reencode field from struct rev-info, as it is not used.
> > This field was introduced in 52883fb, but it hasn't been used since its
> > introduction.
>
> "52883fbd (Teach log family --encoding, 2006-12-25)" is how you
> would refer to existing commit in the history. I'll tweak that part
> of the proposed log message before applying so there is no need to
> resend.
With the usual "git show -s --format=reference", in case a reader didn't know :)
--
D. Ben Knoble
prev parent reply other threads:[~2025-04-25 12:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 21:31 [GSoC PATCH v2] revision: remove log_reencode field from rev_info Lucas Seiki Oshiro
2025-04-22 22:25 ` Junio C Hamano
2025-04-25 12:51 ` D. Ben Knoble [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALnO6CBw0asD2a1iK5UCDX4KXdr1+ua757nt6kEH9fdED2Apvw@mail.gmail.com \
--to=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=lucasseikioshiro@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).