* [GSoC PATCH v2] revision: remove log_reencode field from rev_info
@ 2025-04-22 21:31 Lucas Seiki Oshiro
2025-04-22 22:25 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Lucas Seiki Oshiro @ 2025-04-22 21:31 UTC (permalink / raw)
To: git; +Cc: ps, Lucas Seiki Oshiro
Remove the log_reencode field from struct rev-info, as it is not used.
This field was introduced in 52883fb, but it hasn't been used since its
introduction.
Helped-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
---
Hi!
Since this patch wasn't merged, I'm sending a v2 only applying the nitpick from
the previous review in the commit message :-)
Thanks!
revision.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/revision.h b/revision.h
index 71e984c452..87f8d798c2 100644
--- a/revision.h
+++ b/revision.h
@@ -292,7 +292,6 @@ struct rev_info {
struct string_list *ref_message_ids;
int add_signoff;
const char *extra_headers;
- const char *log_reencode;
const char *subject_prefix;
int patch_name_max;
int no_inline;
--
2.39.5 (Apple Git-154)
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [GSoC PATCH v2] revision: remove log_reencode field from rev_info
2025-04-22 21:31 [GSoC PATCH v2] revision: remove log_reencode field from rev_info Lucas Seiki Oshiro
@ 2025-04-22 22:25 ` Junio C Hamano
2025-04-25 12:51 ` D. Ben Knoble
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2025-04-22 22:25 UTC (permalink / raw)
To: Lucas Seiki Oshiro; +Cc: git, ps
Lucas Seiki Oshiro <lucasseikioshiro@gmail.com> writes:
> Remove the log_reencode field from struct rev-info, as it is not used.
> This field was introduced in 52883fb, but it hasn't been used since its
> introduction.
"52883fbd (Teach log family --encoding, 2006-12-25)" is how you
would refer to existing commit in the history. I'll tweak that part
of the proposed log message before applying so there is no need to
resend.
Thanks.
>
> Helped-by: Patrick Steinhardt <ps@pks.im>
> Signed-off-by: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
> ---
> Hi!
>
> Since this patch wasn't merged, I'm sending a v2 only applying the nitpick from
> the previous review in the commit message :-)
>
> Thanks!
>
> revision.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/revision.h b/revision.h
> index 71e984c452..87f8d798c2 100644
> --- a/revision.h
> +++ b/revision.h
> @@ -292,7 +292,6 @@ struct rev_info {
> struct string_list *ref_message_ids;
> int add_signoff;
> const char *extra_headers;
> - const char *log_reencode;
> const char *subject_prefix;
> int patch_name_max;
> int no_inline;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [GSoC PATCH v2] revision: remove log_reencode field from rev_info
2025-04-22 22:25 ` Junio C Hamano
@ 2025-04-25 12:51 ` D. Ben Knoble
0 siblings, 0 replies; 3+ messages in thread
From: D. Ben Knoble @ 2025-04-25 12:51 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Lucas Seiki Oshiro, git, ps
On Tue, Apr 22, 2025 at 6:26 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Lucas Seiki Oshiro <lucasseikioshiro@gmail.com> writes:
>
> > Remove the log_reencode field from struct rev-info, as it is not used.
> > This field was introduced in 52883fb, but it hasn't been used since its
> > introduction.
>
> "52883fbd (Teach log family --encoding, 2006-12-25)" is how you
> would refer to existing commit in the history. I'll tweak that part
> of the proposed log message before applying so there is no need to
> resend.
With the usual "git show -s --format=reference", in case a reader didn't know :)
--
D. Ben Knoble
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-25 12:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-22 21:31 [GSoC PATCH v2] revision: remove log_reencode field from rev_info Lucas Seiki Oshiro
2025-04-22 22:25 ` Junio C Hamano
2025-04-25 12:51 ` D. Ben Knoble
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).