From: "D. Ben Knoble" <ben.knoble@gmail.com>
To: Kristoffer Haugsbakk <code@khaugsbakk.name>
Cc: "Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org, "Phillip Wood" <phillip.wood123@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Glen Choo" <glencbz@gmail.com>,
"Karthik Nayak" <karthik.188@gmail.com>,
"Denton Liu" <liu.denton@gmail.com>,
motisd8@gmail.com, "Phillip Wood" <phillip.wood@dunelm.org.uk>,
"Patrick Steinhardt" <ps@pks.im>
Subject: Re: [PATCH] doc: explain the impact of stash.index on --autostash options
Date: Mon, 13 Oct 2025 22:18:50 -0400 [thread overview]
Message-ID: <CALnO6CDULtw1UmqHfiqLCH4v6U=MuiECHhYwz1-Omkh8x=9yFg@mail.gmail.com> (raw)
In-Reply-To: <d4dc8042-b996-4889-88cb-f0862a12d09c@app.fastmail.com>
On Mon, Oct 13, 2025 at 8:18 AM Kristoffer Haugsbakk
<code@khaugsbakk.name> wrote:
>
> On Sun, Oct 12, 2025, at 20:04, Ben Knoble wrote:
> >>>[snip]
> >>
> >> Yeah, that is less useful to me (there is a tool, given a commit
> >> object, to figure out at which merge it got merged to the mainline);
> >> I didn't think of a way the information can be useful to general
> >> readers. If the mainline merge was a release or more ago, then it
> >> may make sense to say "commit X, which appeared in version Y, was
> >> broken in such and such way, and here is to fix its breakage"
> >
> > It’s not clear to me if you’d like to see a v2 or not, but given you
> > were already happy to merge in the latest what’s cooking, I don’t mind
> > not sending one ;)
>
> Sorry. I misread a What’s Cooking email[1] as asking why a topic hadn’t
> been picked up. But you were asking about sending another patch on top
> of something which was already in `next`.
Apologies. That's probably my poor wording.
> I wouldn’t have sent that email if I knew it was already in `next` (if I
> had checked better).
Anything I can do to make it easier next time? Appreciate the review, btw :)
--
D. Ben Knoble
prev parent reply other threads:[~2025-10-14 2:19 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-10 18:33 [PATCH 0/9] make stash apply with --index by default D. Ben Knoble
2025-05-10 18:33 ` [PATCH 1/9] t3903: reduce dependencies on previous tests D. Ben Knoble
2025-05-10 18:33 ` [PATCH 2/9] t3905: remove unneeded blank line D. Ben Knoble
2025-05-10 18:33 ` [PATCH 3/9] BreakingChanges: announce stash {apply,pop} will imply --index D. Ben Knoble
2025-05-10 18:33 ` [PATCH 4/9] stash: restore the index by default when breaking changes are enabled D. Ben Knoble
2025-05-10 18:33 ` [PATCH 5/9] t0450: mark stash documentation as a known discrepancy D. Ben Knoble
2025-05-10 18:33 ` [PATCH 6/9] t3903: adjust stash test to account for --[no-]index with breaking changes D. Ben Knoble
2025-05-10 18:33 ` [PATCH 7/9] t3904: adjust stash -p test to account for index states " D. Ben Knoble
2025-05-10 18:33 ` [PATCH 8/9] t3905: adjust stash -u tests for " D. Ben Knoble
2025-05-10 18:33 ` [PATCH 9/9] t3906: adjust stash submodule tests to account " D. Ben Knoble
2025-05-12 12:52 ` [PATCH 0/9] make stash apply with --index by default Junio C Hamano
2025-05-20 14:36 ` D. Ben Knoble
2025-05-20 14:39 ` D. Ben Knoble
2025-09-16 0:37 ` [PATCH v2 0/4] Teach git-stash to use --index from config D. Ben Knoble
2025-09-16 0:37 ` [PATCH v2 1/4] t3903: reduce dependencies on previous tests D. Ben Knoble
2025-09-16 0:37 ` [PATCH v2 2/4] t3905: remove unneeded blank line D. Ben Knoble
2025-09-16 0:37 ` [PATCH v2 3/4] stash: refactor private config globals D. Ben Knoble
2025-09-16 0:37 ` [PATCH v2 4/4] stash: honor stash.index in apply, pop modes D. Ben Knoble
2025-09-16 9:18 ` Phillip Wood
2025-09-16 17:07 ` D. Ben Knoble
2025-09-16 9:24 ` [PATCH v2 0/4] Teach git-stash to use --index from config Phillip Wood
2025-09-16 17:06 ` D. Ben Knoble
2025-09-16 16:49 ` Junio C Hamano
2025-09-22 1:39 ` [PATCH v3 " D. Ben Knoble
2025-09-22 1:39 ` [PATCH v3 1/4] t3903: reduce dependencies on previous tests D. Ben Knoble
2025-09-22 1:39 ` [PATCH v3 2/4] t3905: remove unneeded blank line D. Ben Knoble
2025-09-22 1:39 ` [PATCH v3 3/4] stash: refactor private config globals D. Ben Knoble
2025-09-22 1:39 ` [PATCH v3 4/4] stash: honor stash.index in apply, pop modes D. Ben Knoble
2025-09-22 14:11 ` Phillip Wood
2025-09-24 20:40 ` D. Ben Knoble
2025-09-29 10:01 ` Phillip Wood
2025-10-06 12:59 ` [PATCH] doc: explain the impact of stash.index on --autostash options D. Ben Knoble
2025-10-09 22:54 ` Kristoffer Haugsbakk
2025-10-11 14:44 ` D. Ben Knoble
2025-10-11 17:28 ` Junio C Hamano
2025-10-12 18:04 ` Ben Knoble
2025-10-13 12:17 ` Kristoffer Haugsbakk
2025-10-14 2:18 ` D. Ben Knoble [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALnO6CDULtw1UmqHfiqLCH4v6U=MuiECHhYwz1-Omkh8x=9yFg@mail.gmail.com' \
--to=ben.knoble@gmail.com \
--cc=avarab@gmail.com \
--cc=code@khaugsbakk.name \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=glencbz@gmail.com \
--cc=karthik.188@gmail.com \
--cc=liu.denton@gmail.com \
--cc=motisd8@gmail.com \
--cc=phillip.wood123@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).