From: Antti Halttunen <Antti.Halttunen@iki.fi>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Stefan Beller <sbeller@google.com>
Subject: Re: bug: nested submodules get an absolute gitdir path
Date: Thu, 7 Apr 2016 09:44:13 +0300 [thread overview]
Message-ID: <CALoo-5XQtLsiEneqLdJyi8Wa5pTX_Kz8f7C1H6ir2=J2ZLAyLg@mail.gmail.com> (raw)
In-Reply-To: <xmqqmvp6zsos.fsf@gitster.mtv.corp.google.com>
On Wed, Apr 6, 2016 at 6:02 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Antti Halttunen <Antti.Halttunen@iki.fi> writes:
>
>> Starting with git v2.7.0,
>>
>> submodules two levels deep get a .git contents of:
>> gitdir: /absolute/path/name
>
> I think that this is $gmane/290491
>
> http://thread.gmane.org/gmane.comp.version-control.git/290491
>
> and queued as sb/submodule-helper-clone-regression-fix topic,
> currently included on the 'pu' branch. Can you try it and see if it
> fixes your issue?
it does, thanks.
> Thanks.
>
>>
>> This breaks repos that are moved or copied:
>>
>> fatal: Not a git repository:
>> /tmp/tmp.gIyxKWIC26/repo/.git/modules/sub/modules/sub
>> fatal: 'git status --porcelain' failed in submodule sub
>>
>> The script https://gitlab.com/snippets/17301 reproduces the issue.
>>
>> git bisect points to commit ee8838d1.
>>
>> thanks,
--
antti
prev parent reply other threads:[~2016-04-07 6:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 7:02 bug: nested submodules get an absolute gitdir path Antti Halttunen
2016-04-06 15:02 ` Junio C Hamano
2016-04-07 6:44 ` Antti Halttunen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALoo-5XQtLsiEneqLdJyi8Wa5pTX_Kz8f7C1H6ir2=J2ZLAyLg@mail.gmail.com' \
--to=antti.halttunen@iki.fi \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).