* bug: nested submodules get an absolute gitdir path
@ 2016-04-06 7:02 Antti Halttunen
2016-04-06 15:02 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Antti Halttunen @ 2016-04-06 7:02 UTC (permalink / raw)
To: git
Hi all,
Starting with git v2.7.0,
submodules two levels deep get a .git contents of:
gitdir: /absolute/path/name
This breaks repos that are moved or copied:
fatal: Not a git repository:
/tmp/tmp.gIyxKWIC26/repo/.git/modules/sub/modules/sub
fatal: 'git status --porcelain' failed in submodule sub
The script https://gitlab.com/snippets/17301 reproduces the issue.
git bisect points to commit ee8838d1.
thanks,
--
antti
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: bug: nested submodules get an absolute gitdir path
2016-04-06 7:02 bug: nested submodules get an absolute gitdir path Antti Halttunen
@ 2016-04-06 15:02 ` Junio C Hamano
2016-04-07 6:44 ` Antti Halttunen
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2016-04-06 15:02 UTC (permalink / raw)
To: Antti Halttunen; +Cc: git, Stefan Beller
Antti Halttunen <Antti.Halttunen@iki.fi> writes:
> Starting with git v2.7.0,
>
> submodules two levels deep get a .git contents of:
> gitdir: /absolute/path/name
I think that this is $gmane/290491
http://thread.gmane.org/gmane.comp.version-control.git/290491
and queued as sb/submodule-helper-clone-regression-fix topic,
currently included on the 'pu' branch. Can you try it and see if it
fixes your issue?
Thanks.
>
> This breaks repos that are moved or copied:
>
> fatal: Not a git repository:
> /tmp/tmp.gIyxKWIC26/repo/.git/modules/sub/modules/sub
> fatal: 'git status --porcelain' failed in submodule sub
>
> The script https://gitlab.com/snippets/17301 reproduces the issue.
>
> git bisect points to commit ee8838d1.
>
> thanks,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: bug: nested submodules get an absolute gitdir path
2016-04-06 15:02 ` Junio C Hamano
@ 2016-04-07 6:44 ` Antti Halttunen
0 siblings, 0 replies; 3+ messages in thread
From: Antti Halttunen @ 2016-04-07 6:44 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, Stefan Beller
On Wed, Apr 6, 2016 at 6:02 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Antti Halttunen <Antti.Halttunen@iki.fi> writes:
>
>> Starting with git v2.7.0,
>>
>> submodules two levels deep get a .git contents of:
>> gitdir: /absolute/path/name
>
> I think that this is $gmane/290491
>
> http://thread.gmane.org/gmane.comp.version-control.git/290491
>
> and queued as sb/submodule-helper-clone-regression-fix topic,
> currently included on the 'pu' branch. Can you try it and see if it
> fixes your issue?
it does, thanks.
> Thanks.
>
>>
>> This breaks repos that are moved or copied:
>>
>> fatal: Not a git repository:
>> /tmp/tmp.gIyxKWIC26/repo/.git/modules/sub/modules/sub
>> fatal: 'git status --porcelain' failed in submodule sub
>>
>> The script https://gitlab.com/snippets/17301 reproduces the issue.
>>
>> git bisect points to commit ee8838d1.
>>
>> thanks,
--
antti
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-07 6:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-06 7:02 bug: nested submodules get an absolute gitdir path Antti Halttunen
2016-04-06 15:02 ` Junio C Hamano
2016-04-07 6:44 ` Antti Halttunen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).