git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: git-credential-cache--daemon quits on SIGHUP, can we change it to ignore instead?
Date: Thu, 29 Oct 2015 20:43:58 -0400	[thread overview]
Message-ID: <CAM-tV-_dc_YEE0Dh2T=8+_DcBiq_rvynOw2cFi+8QizkeGTusw@mail.gmail.com> (raw)
In-Reply-To: <20151030001000.GA2123@sigill.intra.peff.net>

On Thu, Oct 29, 2015 at 8:10 PM, Jeff King <peff@peff.net> wrote:
> On Tue, Oct 27, 2015 at 11:46:20PM -0400, Noam Postavsky wrote:
>> Perhaps we could express the auto-spawn more explicitly, something
>> like "git config credential.pre-helper start-cache-daemon". A way to
>> run a command before the credential helpers start would be useful to
>> our magit workaround for this issue (currently we start the daemon
>> before "push", "fetch", and "pull", but it won't work with user
>> aliases that run those commands).
>
> I'm not clear on when the pre-helper would be run. Git runs the helper
> when it needs a credential. What git command would start it?

I was just thinking in terms of our current workaround, it would have
been helpful to be able to run a command just before the helpers are
run. Or in other words, as the first helper. (doing "git -c
credential.helper=foo" puts foo as the last helper).

> I guess the most elegant thing would be to add an "init" command to the
> helper interface. So magit would run:
>
>   git credential init

Although, we could use something like that too, as we're currently
checking the helpers configured and then running git
credential-cache--daemon directly.

> I dunno. It almost seems like adding a credentialcache.ignoreHUP option
> would be less hacky. :)

The pre-helper thing is probably the best way to make the current
hacks less hacky, but maybe not so great for actually fixing the
problem and getting rid of the need for said hacks. :)

> Mostly, I think, because there was a lot of support load in teaching
> people to set up ssh. But I guess a lot of those people are on
> non-Linux platforms.

Hmm, the pre-helper thing would also help for the hack I wrote getting
ssh-agent to autostart and work from Emacs on Windows (ssh-agent on
Windows is a total PITA).

  reply	other threads:[~2015-10-30  0:50 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-10 16:45 git-credential-cache--daemon quits on SIGHUP, can we change it to ignore instead? Noam Postavsky
2015-10-18 15:15 ` Noam Postavsky
2015-10-18 17:58   ` Junio C Hamano
2015-10-19  0:51     ` Noam Postavsky
2015-10-21  2:35     ` Noam Postavsky
2015-10-24 21:47       ` Noam Postavsky
2015-10-25 16:58         ` Junio C Hamano
2015-10-26 21:50           ` Jeff King
2015-10-27  0:50             ` Noam Postavsky
2015-10-27 18:41               ` Jeff King
2015-10-27 19:04                 ` Junio C Hamano
2015-10-27 17:52             ` Junio C Hamano
2015-10-27 18:47               ` Jeff King
2015-10-28  3:46                 ` Noam Postavsky
2015-10-30  0:10                   ` Jeff King
2015-10-30  0:43                     ` Noam Postavsky [this message]
2015-10-30  0:50                       ` Jeff King
2015-10-30  1:20                         ` Noam Postavsky
2015-10-30 21:08                           ` Jeff King
2015-11-09  2:58                             ` Noam Postavsky
2015-11-09 15:53                               ` Jeff King
2015-11-10  1:05                                 ` Noam Postavsky
2015-11-10 12:25                                   ` Jeff King
2015-11-10 12:26                                     ` Jeff King
2015-11-11  0:22                                       ` Noam Postavsky
2015-12-04 18:55                                     ` Junio C Hamano
2015-12-04 19:06                                       ` Jeff King
2015-12-04 20:05                                         ` Junio C Hamano
2015-12-04 23:25                                           ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAM-tV-_dc_YEE0Dh2T=8+_DcBiq_rvynOw2cFi+8QizkeGTusw@mail.gmail.com' \
    --to=npostavs@users.sourceforge.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).