From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: "Git mailing list" <git@vger.kernel.org>,
"Szeder Gábor" <szeder.dev@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Stefan Beller" <sbeller@google.com>
Subject: Re: [PATCH v3 1/1] completion: load completion file for external subcommand
Date: Mon, 7 May 2018 12:39:04 +0200 [thread overview]
Message-ID: <CAM0VKjkTu+OkLM3gvX73mWugxArCVmqRBmWGHiKuLiLRNkkNow@mail.gmail.com> (raw)
In-Reply-To: <20180429164232.29337-2-mail@floga.de>
On Sun, Apr 29, 2018 at 6:42 PM, Florian Gamböck <mail@floga.de> wrote:
> This way we can leverage bash-completion's dynamic loading for git
> subcommands and make it easier for developers to distribute custom
> completion scripts.
The patch and the updated commit message both look good to me.
Thanks for following through.
prev parent reply other threads:[~2018-05-07 10:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-29 16:42 [PATCH v3 0/1] completion: dynamic completion loading Florian Gamböck
2018-04-29 16:42 ` [PATCH v3 1/1] completion: load completion file for external subcommand Florian Gamböck
2018-05-07 10:39 ` SZEDER Gábor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM0VKjkTu+OkLM3gvX73mWugxArCVmqRBmWGHiKuLiLRNkkNow@mail.gmail.com \
--to=szeder.dev@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).