From: Mike McLean <stixmclean@googlemail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>,
Mike McLean <stixmclean@googlemail.com>,
git@vger.kernel.org
Subject: Re: Git Feature Request (Fixdown in interactive rebase)
Date: Wed, 23 Dec 2020 23:28:47 +0000 [thread overview]
Message-ID: <CAM0jFOddeArOtbrKVGP0r3Nh=GHPoKqyZ7v6==iFTMpTus4-Fw@mail.gmail.com> (raw)
In-Reply-To: <X+PR6yms1G9zVcML@camp.crustytoothpaste.net>
I think I was unclear :)
I mean that the new command would take *only* the 2nd commit message.
(By analogy to `fixup` which takes *only* the 1st commit message)
I agree that `squash` currently gives you the concatenation of both
commits ("all", if squashing >2 commits)
On Wed, Dec 23, 2020 at 11:25 PM brian m. carlson
<sandals@crustytoothpaste.net> wrote:
>
> On 2020-12-23 at 23:08:58, Mike McLean wrote:
> > I initially raised this as a FR with my git UI of choice, and was told
> > that it was actually something that git itself would need to do ...
> > and that the standard way to raise Feature Requests was to email this
> > list.
>
> This is absolutely the right place.
>
> > During an interactive rebase, the text file defining the operations
> > has a command option for "fixup".
> > This will squash the target commit into the previous commit (listed
> > above it in the file), and automatically use the commit message of the
> > previous commit (thus bypassing the "choose the commit message"
> > dialog/file).
> >
> > Can we have a similar convenience-command that squashes, and retains
> > the second commit's message? Purpose is the same as the fixup command
> > - saving a bit of time and unnecessary typing during a common
> > operation.
>
> Maybe I'm misunderstanding what you want, but I think the "squash"
> command does what you want. It does invoke the editor to edit it, which
> tends to be useful when working on projects that use a sign-off, since
> otherwise your second commit message would be tacked on after the
> sign-off and other trailers.
>
> If you really want to avoid the editor prompt, you can run your rebase
> like so:
>
> GIT_SEQUENCE_EDITOR="$(git var GIT_EDITOR)" GIT_EDITOR=true git rebase -i
>
> which will avoid spawning an editor except for the todo list and will
> implicitly concatenate the two messages. That will also make any
> "reword" options a no-op, though.
>
> If you were looking for an editor command that just concatenates the two
> messages without an editor prompt, then no, we don't have that, and that
> would be a new feature. I wouldn't use it because most of my projects
> use sign-offs, but I'll let other folks weigh in if that's a feature
> they'd like to see.
> --
> brian m. carlson (he/him or they/them)
> Houston, Texas, US
next prev parent reply other threads:[~2020-12-23 23:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAM0jFOeCE-iTAMkiGE6m8bVNjJRn-BUmbUAP2ANrj4FbhuQG=g@mail.gmail.com>
2020-12-23 23:08 ` Git Feature Request (Fixdown in interactive rebase) Mike McLean
2020-12-23 23:25 ` brian m. carlson
2020-12-23 23:28 ` Mike McLean [this message]
2020-12-23 23:57 ` Junio C Hamano
2020-12-24 0:13 ` Mike McLean
2020-12-24 9:16 ` Johannes Sixt
2020-12-24 22:21 ` Junio C Hamano
2020-12-24 22:54 ` Johannes Sixt
2021-01-06 22:40 ` Johannes Schindelin
2021-01-27 7:55 ` Charvi Mendiratta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM0jFOddeArOtbrKVGP0r3Nh=GHPoKqyZ7v6==iFTMpTus4-Fw@mail.gmail.com' \
--to=stixmclean@googlemail.com \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).