From: Anand Kumria <wildfire@progsoc.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Paul Mackerras <paulus@samba.org>, git@vger.kernel.org
Subject: Re: [PATCH] gitk: Display the date of a tag in a human friendly way.
Date: Sat, 5 Jan 2013 14:05:00 +0000 [thread overview]
Message-ID: <CAM1C4Gm_ea8DgrVhnp_MHmqaF6pyDe98EDA_BPkjvc8M5AO6FQ@mail.gmail.com> (raw)
In-Reply-To: <7vhamwse2c.fsf@alter.siamese.dyndns.org>
Hi Junio,
On 4 January 2013 23:50, Junio C Hamano <gitster@pobox.com> wrote:
> Anand Kumria <wildfire@progsoc.org> writes:
>
>> By selecting a tag within gitk you can display information about it.
>> This information is output by using the command
>>
>> 'git cat-file tag <tagid>'
>>
>> This outputs the *raw* information from the tag, amongst which is the
>> time - in seconds since the epoch. As useful as that value is, I find it
>> a lot easier to read and process time which it is something like:
>>
>> "Mon Dec 31 14:26:11 2012 -0800"
>>
>> This change will modify the display of tags in gitk like so:
>>
>> @@ -1,7 +1,7 @@
>> object 5d417842efeafb6e109db7574196901c4e95d273
>> type commit
>> tag v1.8.1
>> -tagger Junio C Hamano <gitster@pobox.com> 1356992771 -0800
>> +tagger Junio C Hamano <gitster@pobox.com> Mon Dec 31 14:26:11 2012 -0800
>>
>> Git 1.8.1
>> -----BEGIN PGP SIGNATURE-----
>>
>> Signed-off-by: Anand Kumria <wildfire@progsoc.org>
>> ---
>
> Sounds like a sensible thing to do but I didn't check how else
> (other than purely for displaying) this string is used.
As far as I can tell it is only used for display (cached_tagcontent in
gitk) purposes.
> Paul, the patch is not made against your tree, so if you choose to
> take it you would need to strip the leading directory at the top.
Sorry, I didn't know that gitk had been split back out (and
Documentation/gitk.txt still mentions it is part of the git suite).
Regards,
Anand
next prev parent reply other threads:[~2013-01-05 14:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 15:47 [PATCH] gitk: Display the date of a tag in a human friendly way Anand Kumria
2013-01-04 23:50 ` Junio C Hamano
2013-01-05 14:05 ` Anand Kumria [this message]
2013-01-05 19:38 ` Junio C Hamano
2013-02-03 18:37 ` Anand Kumria
2013-02-03 20:12 ` Jonathan Nieder
2013-02-03 20:23 ` Junio C Hamano
2013-04-01 7:25 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM1C4Gm_ea8DgrVhnp_MHmqaF6pyDe98EDA_BPkjvc8M5AO6FQ@mail.gmail.com \
--to=wildfire@progsoc.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).