From: Sean McAllister <smcallis@google.com>
To: Jeff King <peff@peff.net>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Masaya Suzuki <masayasuzuki@google.com>,
Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH v2 3/3] http: automatically retry some requests
Date: Wed, 14 Oct 2020 13:10:46 -0600 [thread overview]
Message-ID: <CAM4o00fO++JMNdES03JKRyxmZtiLjkrJ2nux0-TZYBdH2+0ijA@mail.gmail.com> (raw)
In-Reply-To: <CAM4o00eCKP1+f=xBw4LJfNqrstEnutAe9StxknW9qLMtPBdhKQ@mail.gmail.com>
On Wed, Oct 14, 2020 at 1:09 PM Sean McAllister <smcallis@google.com> wrote:
>
> On Tue, Oct 13, 2020 at 3:14 PM Jeff King <peff@peff.net> wrote:
> >
> > I do think you could be leveraging CURLINFO_RETRY_AFTER rather than
> > implementing your own header parsing, though.
> >
> Ah I didn't know about CURLINFO_RETRY_AFTER, I'll look at that and use
> it if I can.
>
I took a look, it looks like CURLINFO_RETRY_AFTER was only added in
7.66 (September, 2019), so
I don't think it's reasonable to rely on it for getting the
Retry-After value in this case.
next prev parent reply other threads:[~2020-10-14 19:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 19:17 [PATCH v2 1/3] remote-curl: add testing for intelligent retry for HTTP Sean McAllister
2020-10-13 19:17 ` [PATCH v2 2/3] replace CURLOPT_FILE With CURLOPT_WRITEDATA Sean McAllister
2020-10-13 20:46 ` Junio C Hamano
2020-10-13 20:58 ` Jeff King
2020-10-13 21:16 ` Daniel Stenberg
2020-10-14 14:57 ` Jeff King
2020-10-14 14:29 ` Sean McAllister
2020-10-14 17:11 ` Sean McAllister
2020-10-13 19:17 ` [PATCH v2 3/3] http: automatically retry some requests Sean McAllister
2020-10-13 21:14 ` Junio C Hamano
2020-10-14 14:28 ` Sean McAllister
2020-10-14 15:25 ` Junio C Hamano
2020-10-13 21:14 ` Jeff King
2020-10-13 23:45 ` brian m. carlson
2020-10-14 15:17 ` Jeff King
2020-10-14 19:09 ` Sean McAllister
2020-10-14 19:10 ` Sean McAllister [this message]
2020-10-14 19:34 ` Jeff King
2020-10-14 22:38 ` Sean McAllister
2020-10-15 0:04 ` Jonathan Nieder
2020-10-15 16:14 ` Jeff King
2020-10-15 16:24 ` Junio C Hamano
2020-10-14 19:55 ` Jeff King
2020-10-14 22:46 ` Sean McAllister
2020-10-15 16:23 ` Jeff King
2020-10-15 16:33 ` Sean McAllister
2020-10-13 20:40 ` [PATCH v2 1/3] remote-curl: add testing for intelligent retry for HTTP Junio C Hamano
2020-10-14 16:56 ` Sean McAllister
2020-10-14 18:13 ` Junio C Hamano
2020-10-14 18:21 ` Sean McAllister
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM4o00fO++JMNdES03JKRyxmZtiLjkrJ2nux0-TZYBdH2+0ijA@mail.gmail.com \
--to=smcallis@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=masayasuzuki@google.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).