From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t: branch: improve test rollback
Date: Thu, 31 Oct 2013 12:39:29 -0600 [thread overview]
Message-ID: <CAMP44s01ABhU1tsqR+VKH6q6L+MNTDxHEgwfsCboxhP-euSmdA@mail.gmail.com> (raw)
In-Reply-To: <xmqq1u3170l1.fsf@gitster.dls.corp.google.com>
On Thu, Oct 31, 2013 at 12:32 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>> diff --git a/t/t3200-branch.sh b/t/t3200-branch.sh
>> index 0fe7647..33673e0 100755
>> --- a/t/t3200-branch.sh
>> +++ b/t/t3200-branch.sh
>> @@ -329,7 +329,7 @@ test_expect_success 'tracking setup fails on non-matching refspec' '
>> '
>>
>> test_expect_success 'test tracking setup via config' '
>> - git config branch.autosetupmerge true &&
>> + test_config branch.autosetupmerge true &&
>> git config remote.local.url . &&
>> git config remote.local.fetch refs/heads/*:refs/remotes/local/* &&
>
> And "remote.local.*" setting does not follow that "pristine"
> principle, making the result of applying this patch inconsistent.
> Is that desirable?
This patch is *improving* test rollback, it's not making it perfect.
Let not the perfect be the enemy of the good.
--
Felipe Contreras
next prev parent reply other threads:[~2013-10-31 18:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 9:27 [PATCH] t: branch: improve test rollback Felipe Contreras
2013-10-31 18:32 ` Junio C Hamano
2013-10-31 18:39 ` Felipe Contreras [this message]
2013-10-31 18:50 ` Junio C Hamano
2013-10-31 18:56 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMP44s01ABhU1tsqR+VKH6q6L+MNTDxHEgwfsCboxhP-euSmdA@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).