From: Felipe Contreras <felipe.contreras@gmail.com>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] remote-helpers/test-bzr.sh: do not use grep \s
Date: Sun, 7 Apr 2013 04:02:54 -0500 [thread overview]
Message-ID: <CAMP44s06=KCDfQuK1t2ZURoOzmF69pDXF0G6eji6EsiMAoBLbQ@mail.gmail.com> (raw)
In-Reply-To: <201304071048.31790.tboegi@web.de>
On Sun, Apr 7, 2013 at 3:48 AM, Torsten Bögershausen <tboegi@web.de> wrote:
> Using grep "devel\s\+3:" to find at least one whitspace
> is not portable on all grep versions:
> Not all grep versions understand "\s" as a "whitespace".
>
> Use a literal TAB followed by SPACE like this [ ] instead.
> The + as a qualifier for "one or more" is not a basic regular expression:
> use egrep instead of grep.
If "\t" is not possible, I would rather use [:space:].
Cheers.
--
Felipe Contreras
next prev parent reply other threads:[~2013-04-07 9:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-07 8:48 [PATCH] remote-helpers/test-bzr.sh: do not use grep \s Torsten Bögershausen
2013-04-07 9:02 ` Felipe Contreras [this message]
2013-04-07 9:04 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMP44s06=KCDfQuK1t2ZURoOzmF69pDXF0G6eji6EsiMAoBLbQ@mail.gmail.com' \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).