From: Felipe Contreras <felipe.contreras@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
Max Horn <max@quendi.de>, Dusty Phillips <dusty@linux.ca>,
Felipe Contreras <felipe.contreras@gmail.com>
Subject: Re: [PATCH v3 12/20] remote-hg: push to the appropriate branch
Date: Wed, 10 Apr 2013 14:15:53 -0500 [thread overview]
Message-ID: <CAMP44s06gKHiEuZF41OkE7tsBn5PAkyGXvmoiqvN1keKFZczJQ@mail.gmail.com> (raw)
In-Reply-To: <1365441214-21096-13-git-send-email-felipe.contreras@gmail.com>
On Mon, Apr 8, 2013 at 12:13 PM, Felipe Contreras
<felipe.contreras@gmail.com> wrote:
> --- a/contrib/remote-helpers/git-remote-hg
> +++ b/contrib/remote-helpers/git-remote-hg
> @@ -625,6 +625,10 @@ def parse_commit(parser):
> if merge_mark:
> get_merge_files(repo, p1, p2, files)
>
> + # Check if the ref is supposed to be a named branch
> + if ref.startswith('refs/heads/branches/'):
> + extra['branch'] = ref.replace('refs/heads/branches/', '')
This should be more consistent with the rest of the code:
branch = ref[len('refs/heads/branches/'):]
Should I reroll?
--
Felipe Contreras
next prev parent reply other threads:[~2013-04-10 19:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 17:13 [PATCH v3 00/20] remote-hg: general updates Felipe Contreras
2013-04-08 17:13 ` [PATCH v3 01/20] remote-hg: trivial cleanups Felipe Contreras
2013-04-08 17:13 ` [PATCH v3 02/20] remote-hg: add missing config variable in doc Felipe Contreras
2013-04-08 17:13 ` [PATCH v3 03/20] remote-hg: properly report errors on bookmark pushes Felipe Contreras
2013-04-08 17:13 ` [PATCH v3 04/20] remote-hg: fix for files with spaces Felipe Contreras
2013-04-08 17:13 ` [PATCH v3 05/20] remote-hg: make sure fake bookmarks are updated Felipe Contreras
2013-04-08 17:13 ` [PATCH v3 06/20] remote-hg: trivial test cleanups Felipe Contreras
2013-04-08 17:13 ` [PATCH v3 07/20] remote-hg: redirect buggy mercurial output Felipe Contreras
2013-04-08 17:13 ` [PATCH v3 08/20] remote-hg: split bookmark handling Felipe Contreras
2013-04-10 19:14 ` Felipe Contreras
2013-04-10 19:36 ` Junio C Hamano
2013-04-08 17:13 ` [PATCH v3 09/20] remote-hg: refactor export Felipe Contreras
2013-04-08 17:13 ` [PATCH v3 10/20] remote-hg: update remote bookmarks Felipe Contreras
2013-04-08 17:13 ` [PATCH v3 11/20] remote-hg: update tags globally Felipe Contreras
2013-04-08 17:13 ` [PATCH v3 12/20] remote-hg: push to the appropriate branch Felipe Contreras
2013-04-10 19:15 ` Felipe Contreras [this message]
2013-04-08 17:13 ` [PATCH v3 13/20] remote-hg: force remote push Felipe Contreras
2013-04-08 17:13 ` [PATCH v3 14/20] remote-hg: show more proper errors Felipe Contreras
2013-04-08 17:13 ` [PATCH v3 15/20] remote-hg: add basic author tests Felipe Contreras
2013-04-08 17:13 ` [PATCH v3 16/20] remote-hg: add simple mail test Felipe Contreras
2013-04-08 17:13 ` [PATCH v3 17/20] remote-hg: add 'insecure' option Felipe Contreras
2013-04-08 17:13 ` [PATCH v3 18/20] remote-hg: fix bad state issue Felipe Contreras
2013-04-08 17:13 ` [PATCH v3 19/20] remote-hg: document location of stored hg repository Felipe Contreras
2013-04-08 17:13 ` [PATCH v3 20/20] remote-hg: fix bad file paths Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMP44s06gKHiEuZF41OkE7tsBn5PAkyGXvmoiqvN1keKFZczJQ@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=dusty@linux.ca \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=max@quendi.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).