From: Felipe Contreras <felipe.contreras@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Marius Storm-Olsen <marius@trolltech.com>,
Jim Meyering <jim@meyering.net>
Subject: Re: [PATCH 3/3] t: mailmap: add simple name translation test
Date: Sun, 5 Feb 2012 00:19:53 +0200 [thread overview]
Message-ID: <CAMP44s0Z=k6VBfv0HOGHyMBLRcPauK7K5RNvuRDbfq5=5aKVpg@mail.gmail.com> (raw)
In-Reply-To: <20120204211544.GC3278@burratino>
On Sat, Feb 4, 2012 at 11:15 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Felipe Contreras wrote:
>
>> Title: mailmap: add simple name translation test
>
> Thanks. I guess you think I'm stupid. I have no idea how I can
> correct that assumption and help you to actually work with me to make
> the code better. :/
You mean the commit message, you haven't made any comment about the code.
If you want to know why I had to modify those test assertions, you
really need to look at the code. In essence; all of them use the same
repo, and obviously adding a new commit message changes the output of
the commands.
--
Felipe Contreras
next prev parent reply other threads:[~2012-02-04 22:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-04 19:50 [PATCH 0/3] blame: fix output with mailmap Felipe Contreras
2012-02-04 19:50 ` [PATCH 1/3] blame: fix email " Felipe Contreras
2012-02-04 23:39 ` Jeff King
2012-02-05 19:57 ` Thomas Rast
2012-02-05 20:58 ` Felipe Contreras
2012-02-06 4:09 ` Jeff King
2012-02-04 19:50 ` [PATCH 2/3] t: mailmap: add 'git blame -e' tests Felipe Contreras
2012-02-04 20:10 ` Jonathan Nieder
2012-02-04 21:04 ` Felipe Contreras
2012-02-04 21:13 ` Jonathan Nieder
2012-02-04 21:59 ` Felipe Contreras
2012-02-05 20:38 ` Junio C Hamano
2012-02-05 21:07 ` Felipe Contreras
2012-02-04 19:50 ` [PATCH 3/3] t: mailmap: add simple name translation test Felipe Contreras
2012-02-04 20:12 ` Jonathan Nieder
2012-02-04 21:05 ` Felipe Contreras
2012-02-04 21:15 ` Jonathan Nieder
2012-02-04 22:19 ` Felipe Contreras [this message]
2012-02-04 23:42 ` Jeff King
2012-02-06 21:32 ` Felipe Contreras
2012-02-05 6:17 ` Jonathan Nieder
2012-02-06 21:18 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMP44s0Z=k6VBfv0HOGHyMBLRcPauK7K5RNvuRDbfq5=5aKVpg@mail.gmail.com' \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jim@meyering.net \
--cc=jrnieder@gmail.com \
--cc=marius@trolltech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).