From: Felipe Contreras <felipe.contreras@gmail.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Thomas Rast <trast@student.ethz.ch>,
Stephen Boyd <bebarino@gmail.com>
Subject: Re: [PATCH v2 2/2] format-patch: add format.cover-letter configuration
Date: Sat, 6 Apr 2013 10:02:32 -0600 [thread overview]
Message-ID: <CAMP44s0Zzdb-1A0ej5Ly_501sv0OOOrHi86GWT9NYkndbiggeg@mail.gmail.com> (raw)
In-Reply-To: <CALkWK0kMTt6wDv6sUVe9CbX-WSx=XH+PF6eQ6oXYFjcp_Yi+aQ@mail.gmail.com>
On Sat, Apr 6, 2013 at 6:43 AM, Ramkumar Ramachandra <artagnon@gmail.com> wrote:
> Felipe Contreras wrote:
>> Also, add a new option: 'auto', so if there's more than one patch, the
>> cover letter is generated, otherwise it's not.
>
> Awesome! I wanted to fix this myself, but got sidetracked with the
> whole submodules thing.
>
>> +format.cover-letter::
>> + Allows to configure the --cover-letter option of format-patch by
>> + default. In addition, you can set it to 'auto' to automatically
>> + determine based on the number of patches (generate if there's more than
>> + one).
>> +
>
> Perhaps you can clarify this: Controls whether to generate a
> cover-letter when format-patch is invoked. Can be true, false, or
> auto. "auto" generates a cover-letter only when generating more than
> one patch.
That's good, but I believe if we say it's a boolean, true and false
are implied, and then we have an extra "auto".
--
Felipe Contreras
next prev parent reply other threads:[~2013-04-06 17:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-06 9:03 [PATCH v2 0/2] send-email: couple of improvements Felipe Contreras
2013-04-06 9:03 ` [PATCH v2 1/2] send-email: make annotate configurable Felipe Contreras
2013-04-07 3:32 ` Junio C Hamano
2013-04-07 6:54 ` Felipe Contreras
2013-04-06 9:03 ` [PATCH v2 2/2] format-patch: add format.cover-letter configuration Felipe Contreras
2013-04-06 12:43 ` Ramkumar Ramachandra
2013-04-06 16:02 ` Felipe Contreras [this message]
2013-04-06 17:43 ` Matthieu Moy
2013-04-06 17:43 ` Matthieu Moy
2013-04-07 3:32 ` Junio C Hamano
2013-04-07 5:46 ` Felipe Contreras
2013-04-06 17:47 ` [PATCH v2 0/2] send-email: couple of improvements Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMP44s0Zzdb-1A0ej5Ly_501sv0OOOrHi86GWT9NYkndbiggeg@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=artagnon@gmail.com \
--cc=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).