git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git <git@vger.kernel.org>, Jeff King <peff@peff.net>,
	Emily Shaffer <emilyshaffer@google.com>
Subject: Re: [PATCH] Add project-wide .vimrc configuration
Date: Tue, 8 Dec 2020 20:32:32 -0600	[thread overview]
Message-ID: <CAMP44s0nno90=xKmiZ0=PYQKraSwev7hmEUXfHoFDU3FR37KCw@mail.gmail.com> (raw)
In-Reply-To: <xmqqy2i74wgv.fsf@gitster.c.googlers.com>

On Tue, Dec 8, 2020 at 7:08 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
> > It's not efficient that everyone must set specific configurations in all
> > their ~/.vimrc files; we can have a project-wide .vimrc that everyone
> > can use.
>
> Does .vimrc gets used from the current directory?  If so, just like
> clang-format, it makes sense to place it with dot-prefix at the root
> of the project, like this patch does.  But ...

Actually no. I tested this with "vim Documentation/git-pull.txt", and
that works fine, but apparently only from that directory.

I'm investigating other solutions.

> > By default it's ignored, you need the following in your ~/.vimrc
> >
> >   set exrc
> >   set secure
>
> ... it does not sound like it is the case.
>
> And I am sensing that this ".vimrc that happens in the current
> directory is not used by default" is not such a well known fact
> among vim users (otherwise you wouldn't be writing it here), and if
> that is the case, I am afraid that this invites an unneeded end-user
> confusion when they see dot-commandname-rc file and see its contents
> not honored at all.

I'd say at least 90% of what vim does is not well known for most vim uses.

> Whether it is well known by intended audience that it is by default
> unused, we should give the instruction we see above (and below, up
> to the description of how to override) in a comment at the beginning
> of the file, I think.  Then, once the user follows the insn, the new
> file added by this patch would start working without any further user
> action, which is very nice.

Right. That makes sense. I'll add the instructions to the next version
once I find a good alternative for exrc.

Cheers.

-- 
Felipe Contreras

  reply	other threads:[~2020-12-09  2:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-09  0:26 [PATCH] Add project-wide .vimrc configuration Felipe Contreras
2020-12-09  1:08 ` Junio C Hamano
2020-12-09  2:32   ` Felipe Contreras [this message]
2020-12-09  1:18 ` Aaron Schrab
2020-12-09  3:15   ` Junio C Hamano
2020-12-09  6:28   ` Felipe Contreras
2020-12-09  1:32 ` Denton Liu
2020-12-09  6:20   ` Felipe Contreras
2020-12-09  2:23 ` brian m. carlson
2020-12-09  6:36   ` Felipe Contreras
2020-12-09  6:54     ` Junio C Hamano
2020-12-09  7:16       ` Felipe Contreras
2020-12-09  8:13         ` Junio C Hamano
2020-12-09  8:52           ` Felipe Contreras
2020-12-09 16:18           ` Randall S. Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMP44s0nno90=xKmiZ0=PYQKraSwev7hmEUXfHoFDU3FR37KCw@mail.gmail.com' \
    --to=felipe.contreras@gmail.com \
    --cc=emilyshaffer@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).