From: Felipe Contreras <felipe.contreras@gmail.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Jeff King <peff@peff.net>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH v2 10/11] sha1_name: reorganize get_sha1_basic()
Date: Wed, 8 May 2013 02:42:13 -0500 [thread overview]
Message-ID: <CAMP44s0yWXHAPAE3vmFpSpVyHi+SeHJEXBS_y4sJw2eP7H-ADQ@mail.gmail.com> (raw)
In-Reply-To: <CALkWK0ktoQg5pd-tSiP=wn-3JGv-N7OHK_FkNjPx5HycdjBsKw@mail.gmail.com>
On Wed, May 8, 2013 at 2:39 AM, Ramkumar Ramachandra <artagnon@gmail.com> wrote:
> Felipe Contreras wrote:
>> ---
>> sha1_name.c | 30 +++++++++++++++++++-----------
>> 1 file changed, 19 insertions(+), 11 deletions(-)
>
> How has this changed since my eyeballing of the previous version? An
> inter-diff would be nice: having spent a significant amount of time
> looking at this area, I can confirm that the patch is Correct.
You mean this compared to v4? It hasn't changed.
--
Felipe Contreras
next prev parent reply other threads:[~2013-05-08 7:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 21:55 [PATCH v2 00/11] sha1_name: improvements Felipe Contreras
2013-05-07 21:55 ` [PATCH v2 01/11] tests: at-combinations: simplify setup Felipe Contreras
2013-05-07 21:55 ` [PATCH v2 02/11] tests: at-combinations: check ref names directly Felipe Contreras
2013-05-08 5:55 ` Junio C Hamano
2013-05-08 6:03 ` Felipe Contreras
2013-05-07 21:55 ` [PATCH v2 03/11] tests: at-combinations: improve nonsense() Felipe Contreras
2013-05-08 5:55 ` Junio C Hamano
2013-05-08 6:49 ` Felipe Contreras
2013-05-07 21:55 ` [PATCH v2 04/11] tests: at-combinations: increase coverage Felipe Contreras
2013-05-07 21:55 ` [PATCH v2 05/11] tests: at-combinations: @{N} versus HEAD@{N} Felipe Contreras
2013-05-07 21:55 ` [PATCH v2 06/11] sha1_name: remove no-op Felipe Contreras
2013-05-07 21:55 ` [PATCH v2 07/11] sha1_name: remove unnecessary braces Felipe Contreras
2013-05-07 21:55 ` [PATCH v2 08/11] sha1_name: avoid Yoda conditions Felipe Contreras
2013-05-07 21:55 ` [PATCH v2 09/11] sha1_name: don't waste cycles in the @-parsing loop Felipe Contreras
2013-05-07 21:55 ` [PATCH v2 10/11] sha1_name: reorganize get_sha1_basic() Felipe Contreras
2013-05-08 7:39 ` Ramkumar Ramachandra
2013-05-08 7:42 ` Felipe Contreras [this message]
2013-05-08 18:18 ` Junio C Hamano
2013-05-08 18:41 ` Junio C Hamano
2013-05-08 20:39 ` Felipe Contreras
2013-05-08 21:51 ` Junio C Hamano
2013-05-08 22:06 ` Felipe Contreras
2013-05-07 21:55 ` [PATCH v2 11/11] sha1_name: check @{-N} errors sooner Felipe Contreras
2013-05-07 22:11 ` [PATCH v2 00/11] sha1_name: improvements Felipe Contreras
2013-05-08 5:56 ` Junio C Hamano
2013-05-08 10:44 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMP44s0yWXHAPAE3vmFpSpVyHi+SeHJEXBS_y4sJw2eP7H-ADQ@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).