From: Felipe Contreras <felipe.contreras@gmail.com>
To: "Ville Skyttä" <ville.skytta@iki.fi>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
bash-completion-devel@lists.alioth.debian.org,
git@vger.kernel.org
Subject: Re: [Bash-completion-devel] [PATCH v2] completion: add new git_complete helper
Date: Sun, 22 Apr 2012 15:58:48 +0300 [thread overview]
Message-ID: <CAMP44s10iy64dLXJtScijeQne0ufnwrmSyvdRT0Szyf9b2kCGA@mail.gmail.com> (raw)
In-Reply-To: <4F92F0D2.1090609@iki.fi>
2012/4/21 Ville Skyttä <ville.skytta@iki.fi>:
> On 2012-04-21 18:41, Felipe Contreras wrote:
>
>> Still, I don't see the point in avoiding 'git_complete' and making our
>> lifes more difficult.
>
> I'm not aware of ways it'd make people's lifes more difficult, but if
> git_complete is a function intended for completion purposes, I'd
> personally not name it git* because it'd interfere for example with
> completing git<TAB> by being included in the suggested completions even
> though it's never meant to be used that way. Prefixing for example with
> underscore doesn't avoid the problem completely, but makes it less
> likely to happen.
That's actually a good point, I forgot that functions are also completed.
Cheers.
--
Felipe Contreras
next prev parent reply other threads:[~2012-04-22 12:58 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-15 21:20 [PATCH v2] completion: add new git_complete helper Felipe Contreras
2012-04-15 21:37 ` Jonathan Nieder
2012-04-16 10:49 ` Felipe Contreras
2012-04-16 15:54 ` Junio C Hamano
2012-04-16 16:07 ` Jonathan Nieder
2012-04-16 16:32 ` Junio C Hamano
2012-04-16 20:04 ` Felipe Contreras
2012-04-16 20:09 ` Jonathan Nieder
2012-04-16 20:30 ` Felipe Contreras
2012-04-16 20:33 ` Jonathan Nieder
2012-04-16 20:42 ` Felipe Contreras
2012-04-16 20:46 ` Jonathan Nieder
2012-04-16 20:51 ` Felipe Contreras
2012-04-16 20:59 ` Jonathan Nieder
2012-04-21 7:20 ` Ville Skyttä
2012-04-21 15:41 ` [Bash-completion-devel] " Felipe Contreras
2012-04-21 17:39 ` Ville Skyttä
2012-04-22 12:58 ` Felipe Contreras [this message]
2012-04-16 20:51 ` Junio C Hamano
2012-04-16 21:09 ` Felipe Contreras
2012-04-16 22:44 ` Jonathan Nieder
2012-04-16 23:04 ` Felipe Contreras
2012-04-16 23:05 ` Jonathan Nieder
2012-04-16 23:16 ` Jonathan Nieder
2012-04-17 7:10 ` Felipe Contreras
2012-04-17 7:36 ` Jonathan Nieder
2012-04-17 7:56 ` Felipe Contreras
2012-04-17 8:06 ` Jonathan Nieder
2012-04-17 8:22 ` Jonathan Nieder
2012-04-16 16:00 ` Jonathan Nieder
2012-04-16 22:15 ` SZEDER Gábor
2012-04-16 22:33 ` Felipe Contreras
2012-04-17 15:50 ` Junio C Hamano
2012-04-17 16:13 ` Felipe Contreras
2012-04-17 18:15 ` Junio C Hamano
2012-04-17 20:53 ` Felipe Contreras
2012-04-17 21:08 ` Jonathan Nieder
2012-04-17 22:14 ` SZEDER Gábor
2012-04-17 22:19 ` Felipe Contreras
2012-04-17 17:50 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMP44s10iy64dLXJtScijeQne0ufnwrmSyvdRT0Szyf9b2kCGA@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=bash-completion-devel@lists.alioth.debian.org \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=ville.skytta@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).