From: Felipe Contreras <felipe.contreras@gmail.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] git-prompt.sh: colorize ZSH prompt
Date: Sat, 11 May 2013 17:29:52 -0500 [thread overview]
Message-ID: <CAMP44s1B+FfdKebpTq+AwHP3YCiiVc++rtc8wqOn8EOy1dyLwA@mail.gmail.com> (raw)
In-Reply-To: <1368310739-24099-1-git-send-email-artagnon@gmail.com>
On Sat, May 11, 2013 at 5:18 PM, Ramkumar Ramachandra
<artagnon@gmail.com> wrote:
> Add colors suitable for use in the ZSH prompt. Having learnt that the
> ZSH equivalent of PROMPT_COMMAND is precmd (), you can now use
> GIT_PS1_SHOWCOLORHINTS with ZSH.
>
> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
> ---
> You like this more? I don't mind going either way.
Not really. If we need to avoid the \[\], it makes sense to have a
separate function, but what I meant is that this function should be
initially on the same file, and created in a separate patch.
--
Felipe Contreras
next prev parent reply other threads:[~2013-05-11 22:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-11 16:25 [PATCH 0/2] Colored prompt for zsh Ramkumar Ramachandra
2013-05-11 16:25 ` [PATCH 1/2] git-prompt.sh: strip unnecessary space in prompt string Ramkumar Ramachandra
2013-05-13 4:57 ` Junio C Hamano
2013-05-13 7:40 ` Ramkumar Ramachandra
2013-05-13 9:17 ` SZEDER Gábor
2013-05-13 10:13 ` Ramkumar Ramachandra
2013-05-13 11:05 ` SZEDER Gábor
2013-05-13 11:11 ` SZEDER Gábor
2013-05-13 13:58 ` Junio C Hamano
2013-05-13 14:21 ` Ramkumar Ramachandra
2013-05-11 16:25 ` [PATCH 2/2] git-prompt.zsh: introduce thin ZSH wrapper Ramkumar Ramachandra
2013-05-11 21:26 ` Felipe Contreras
2013-05-11 22:18 ` [PATCH v2] git-prompt.sh: colorize ZSH prompt Ramkumar Ramachandra
2013-05-11 22:29 ` Felipe Contreras [this message]
2013-05-11 22:40 ` Ramkumar Ramachandra
2013-05-11 23:06 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMP44s1B+FfdKebpTq+AwHP3YCiiVc++rtc8wqOn8EOy1dyLwA@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).