Re: [PATCH 1/2] transport-helper: report errors properly

[Felipe Contreras <felipe.contreras@gmail.com>]

On Thu, Apr 11, 2013 at 1:49 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> On Thu, Apr 11, 2013 at 11:59 AM, Jeff King <peff@peff.net> wrote:
>>
>>> But I give up on you. I find most of your commit messages lacking in
>>> details and motivation, making assumptions that the reader is as
>>> familiar with the code when reading the commit as you are when you wrote
>>> it. I tried to help by suggesting in review that you elaborate. That
>>> didn't work. So I tried to help by writing the text myself. But clearly
>>> I am not going to convince you that it is valuable, even if it requires
>>> no work at all from you, so I have nothing else to say on the matter.
>>
>> Me neither. I picked your solution, but that's not enough, you
>> *always* want me to do EXACTLY what you want, and never argue back.
>>
>> It's not going to happen. There's nothing wrong with disagreeing.
>
> Heh, it seems that I was late for the party.
>
> Writing only minimally sufficient in the log messages is fine for
> your own project. We won't decide nor dictate the policy for your
> project for you.
>
> But _this_ project wants its log messages to be understandable by
> people who you may disagree with and who may have shorter memory
> span than you do.

Having a shorter memory span is irrelevant when you are _never_ going
to go back and ask the question the commit message is answering. And
if it indeed is an important question, the answer belongs in the code
comments.

> Disagreeing with that policy is fine.  You need
> to learn to disagree but accept to be part of the project.

Yeah, I accept that you will commit whatever you want, but I still
don't think this verbosity serves the purpose you think it serves.
Some one-liners deserve pages of commit messages, but this one is not
one of them. People are easily deceived, and because you saw one
commit message that needed more information, you think all of them do,
but no, some don't don't, and this is one of them. It's not serving
any real purpose.

--
Felipe Contreras