From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Elijah Newren <newren@gmail.com>,
Sverre Rabbelier <srabbelier@gmail.com>
Subject: Re: [PATCH 1/3] fast-export: improve argument parsing
Date: Thu, 9 May 2013 18:33:15 -0500 [thread overview]
Message-ID: <CAMP44s1GAeu5v5xqLu8BgisprmWN=C8zoFYNidoyBPXmu-cvJQ@mail.gmail.com> (raw)
In-Reply-To: <7vy5bn68eu.fsf@alter.siamese.dyndns.org>
On Thu, May 9, 2013 at 6:27 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> On Thu, May 9, 2013 at 5:17 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>>
>>>> We don't want to pass arguments specific to fast-export to
>>>> setup_revisions.
>>>
>>> Interesting. What bad things happen with the current order?
>>>
>>> Does "fast-export --export-marks=foo" causes setup_revisions() to
>>> mistakenly eat --export-marks=foo and barf?
>>
>> No, apparently it skips them. But try 'git fast-export --export-marks
>> marks HEAD'.
>
> That is the kind of thing that needs to be said, not in the
> discussion but in the history, either in the log or in a new test,
> or both.
If only I had known that when I wrote the commit message.
--
Felipe Contreras
next prev parent reply other threads:[~2013-05-09 23:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 1:31 [PATCH 0/3] Support for old:new remote-helper push Felipe Contreras
2013-05-09 1:31 ` [PATCH 1/3] fast-export: improve argument parsing Felipe Contreras
2013-05-09 22:17 ` Junio C Hamano
2013-05-09 23:02 ` Felipe Contreras
2013-05-09 23:27 ` Junio C Hamano
2013-05-09 23:33 ` Felipe Contreras [this message]
2013-05-10 4:49 ` Junio C Hamano
2013-05-09 1:31 ` [PATCH 2/3] fast-export: add new --refspec option Felipe Contreras
2013-05-09 22:32 ` Junio C Hamano
2013-05-09 22:53 ` Felipe Contreras
2013-05-09 23:23 ` Junio C Hamano
2013-05-09 23:32 ` Felipe Contreras
2013-05-10 0:21 ` Junio C Hamano
2013-05-10 0:44 ` Felipe Contreras
2013-05-10 1:13 ` Junio C Hamano
2013-05-10 6:42 ` Johannes Sixt
2013-05-16 9:15 ` Felipe Contreras
2013-05-09 1:31 ` [PATCH 3/3] transport-helper: add support for old:new refspec Felipe Contreras
2013-05-16 9:15 ` [PATCH 0/3] Support for old:new remote-helper push Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMP44s1GAeu5v5xqLu8BgisprmWN=C8zoFYNidoyBPXmu-cvJQ@mail.gmail.com' \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).