From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Antoine Pelisse <apelisse@gmail.com>, git <git@vger.kernel.org>
Subject: Re: [PATCH] remote-hg: fix path when cloning with tilde expansion
Date: Sat, 10 Aug 2013 02:07:45 -0500 [thread overview]
Message-ID: <CAMP44s1NE-ac_tWej9EhMWJLRm7aq1WKOm17fZm5y_aA4ppq5g@mail.gmail.com> (raw)
In-Reply-To: <7v38qi2g63.fsf@alter.siamese.dyndns.org>
On Sat, Aug 10, 2013 at 1:50 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> If I clone ~/git, and then change my username, and move my home
>> directory, doing a 'git fetch' in ~/git wouldn't work anymore, because
>> we have expanded the path and fixed it to my old home, if instead we
>> simply return without fixing, it would still work just fine.
>
> Antoine's patch runs expanduser() only to see if the given one gets
> modified to absolute path, and makes fix_path() return without
> calling the extra 'git config', so it is my understanding that the
> above describes exactly what the patch does. Am I reading the patch
> incorrectly?
Antoine's *second* patch, which I missed, does that, yeah. That should
work fine.
--
Felipe Contreras
next prev parent reply other threads:[~2013-08-10 7:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 20:12 [PATCH] remote-hg: fix path when cloning with tilde expansion Antoine Pelisse
2013-08-05 20:30 ` Felipe Contreras
2013-08-05 20:32 ` Antoine Pelisse
2013-08-09 17:13 ` Antoine Pelisse
2013-08-09 18:49 ` Junio C Hamano
2013-08-09 20:09 ` Antoine Pelisse
2013-08-09 20:53 ` Junio C Hamano
2013-08-09 21:19 ` Antoine Pelisse
2013-08-09 21:45 ` Junio C Hamano
2013-08-09 21:55 ` Antoine Pelisse
2013-08-09 21:55 ` Felipe Contreras
2013-08-09 22:15 ` Junio C Hamano
2013-08-09 22:28 ` Felipe Contreras
2013-08-09 23:39 ` Junio C Hamano
2013-08-09 23:43 ` Felipe Contreras
2013-08-10 5:18 ` Junio C Hamano
2013-08-10 6:39 ` Felipe Contreras
2013-08-10 6:50 ` Junio C Hamano
2013-08-10 7:07 ` Felipe Contreras [this message]
2013-08-10 15:15 ` Antoine Pelisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMP44s1NE-ac_tWej9EhMWJLRm7aq1WKOm17fZm5y_aA4ppq5g@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=apelisse@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).