From: Felipe Contreras <felipe.contreras@gmail.com>
To: Richard Hansen <rhansen@bbn.com>
Cc: git@vger.kernel.org, Sverre Rabbelier <srabbelier@gmail.com>
Subject: Re: [PATCH v5 12/10] remote-bzr: support the new 'force' option
Date: Mon, 11 Nov 2013 12:15:53 -0600 [thread overview]
Message-ID: <CAMP44s1SC0SQLKWG13-FRwvX6AB6pZmn+z0f1ovnuawC6wcb+w@mail.gmail.com> (raw)
In-Reply-To: <52811E1F.4090500@bbn.com>
On Mon, Nov 11, 2013 at 12:12 PM, Richard Hansen <rhansen@bbn.com> wrote:
> On 2013-11-11 06:51, Felipe Contreras wrote:
>> def do_option(parser):
>> global force
>> _, key, value = parser.line.split(' ')
>
> I'm surprised you prefer this over 'key, val = parser[1:3]' or even
> '_, key, val = parser[:]'. Are you intending to eventually remove
> Parser.__getitem__()?
I don't, actually. I'm fine with either way.
Cheers.
--
Felipe Contreras
next prev parent reply other threads:[~2013-11-11 18:16 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 9:36 [PATCH v5 10/10] transport-helper: add support to delete branches Felipe Contreras
2013-10-31 9:36 ` [PATCH v5 00/10] transport-helper: updates Felipe Contreras
2013-10-31 17:59 ` Max Horn
2013-10-31 18:10 ` Junio C Hamano
2013-10-31 18:30 ` Felipe Contreras
2013-10-31 18:34 ` Junio C Hamano
2013-10-31 18:41 ` Max Horn
2013-11-11 5:09 ` [PATCH v5 11/10] test-hg.sh: tests are now expected to pass Richard Hansen
2013-11-11 5:10 ` [PATCH v5 12/10] remote-bzr: support the new 'force' option Richard Hansen
2013-11-11 11:51 ` Felipe Contreras
2013-11-11 18:12 ` Richard Hansen
2013-11-11 18:15 ` Felipe Contreras [this message]
2013-10-31 9:36 ` [PATCH v5 01/10] transport-helper: fix extra lines Felipe Contreras
2013-10-31 18:16 ` Junio C Hamano
2013-10-31 9:36 ` [PATCH v5 08/10] fast-import: add support to delete refs Felipe Contreras
2013-10-31 18:41 ` Max Horn
2013-10-31 9:36 ` [PATCH v5 05/10] fast-export: improve argument parsing Felipe Contreras
2013-10-31 9:36 ` [PATCH v5 06/10] fast-export: add new --refspec option Felipe Contreras
2013-10-31 18:26 ` Junio C Hamano
2013-10-31 18:41 ` Felipe Contreras
2013-11-06 21:00 ` Junio C Hamano
2013-11-06 22:14 ` Jeff King
2013-11-06 22:31 ` Junio C Hamano
2013-11-06 22:41 ` Junio C Hamano
2013-11-08 23:44 ` Junio C Hamano
2013-11-09 0:06 ` Jeff King
2013-11-07 1:00 ` Felipe Contreras
2013-10-31 9:36 ` [PATCH v5 03/10] transport-helper: add 'force' to 'export' helpers Felipe Contreras
2013-10-31 18:21 ` Junio C Hamano
2013-10-31 18:55 ` Felipe Contreras
2013-10-31 19:07 ` Junio C Hamano
2013-11-01 14:49 ` Junio C Hamano
2013-11-01 15:37 ` Felipe Contreras
2013-11-01 16:35 ` Junio C Hamano
2013-11-01 17:28 ` Eric Sunshine
2013-11-11 5:01 ` [PATCH] fixup! " Richard Hansen
2013-10-31 9:36 ` [PATCH v5 09/10] fast-export: add support to delete refs Felipe Contreras
2013-10-31 19:29 ` Max Horn
2013-10-31 19:41 ` Felipe Contreras
2013-10-31 19:47 ` Max Horn
2013-10-31 19:53 ` Felipe Contreras
2013-10-31 22:38 ` Max Horn
2013-10-31 9:36 ` [PATCH v5 07/10] transport-helper: add support for old:new refspec Felipe Contreras
2013-10-31 9:36 ` [PATCH v5 04/10] transport-helper: check for 'forced update' message Felipe Contreras
2013-10-31 9:36 ` [PATCH v5 02/10] transport-helper: don't update refs in dry-run Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMP44s1SC0SQLKWG13-FRwvX6AB6pZmn+z0f1ovnuawC6wcb+w@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=rhansen@bbn.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).