From mboxrd@z Thu Jan  1 00:00:00 1970
From: Felipe Contreras <felipe.contreras@gmail.com>
Subject: Re: [PATCH 5/7] completion: fix expansion issues in __gitcomp_nl()
Date: Sat, 17 Nov 2012 12:50:39 +0100
Message-ID: <CAMP44s1ZgNM1WXPu_-q9aFkz8Ui3czwcUqHWvs7Yspi_p9kuNQ@mail.gmail.com>
References: <1353150353-29874-1-git-send-email-szeder@ira.uka.de>
	<1353150353-29874-6-git-send-email-szeder@ira.uka.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
	Jonathan Nieder <jrnieder@gmail.com>,
	Junio C Hamano <gitster@pobox.com>
To: =?UTF-8?Q?SZEDER_G=C3=A1bor?= <szeder@ira.uka.de>
X-From: git-owner@vger.kernel.org Sat Nov 17 12:50:54 2012
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@plane.gmane.org
Received: from vger.kernel.org ([209.132.180.67])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <git-owner@vger.kernel.org>)
	id 1TZgvF-0007E3-Tx
	for gcvg-git-2@plane.gmane.org; Sat, 17 Nov 2012 12:50:54 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751635Ab2KQLuk convert rfc822-to-quoted-printable (ORCPT
	<rfc822;gcvg-git-2@m.gmane.org>); Sat, 17 Nov 2012 06:50:40 -0500
Received: from mail-ob0-f174.google.com ([209.85.214.174]:52345 "EHLO
	mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751596Ab2KQLuj convert rfc822-to-8bit (ORCPT
	<rfc822;git@vger.kernel.org>); Sat, 17 Nov 2012 06:50:39 -0500
Received: by mail-ob0-f174.google.com with SMTP id wc20so3603334obb.19
        for <git@vger.kernel.org>; Sat, 17 Nov 2012 03:50:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        bh=li6NLbLoOu9pjnZdn9fqfWyAjK8jniROcQaOVi6CNwI=;
        b=Kz168PQqFj3f9NQR0zebvp2uYw/8skpN+DZ5l+y4wDV+Txgb1zUU1bcqhBuIItoAzB
         0J++HJvP1Tr0kXsYByVQeAlqHcrAL+mAk1STBJxqUXDutcKv0E3Ov7Kn99NDT/s5uDFL
         zB031LqFBO4EF9a5k2AXi4i8fu7uZW7ovlNi1gRHsDxhFO8OQIzpRGQDdv5QWMLgcq19
         7j28waqWq5et92fxZq6r9mqplbRRmyt22FzVStmovdxElx9wf2XCsvXQAAINpx0mkIMJ
         quLqdAHI2i52J8JRX+rb+pUFdjSaOpqfaS71duhYqJuIO8oSslGRaBl3DibOiRncDYBo
         V00g==
Received: by 10.182.52.105 with SMTP id s9mr6273452obo.25.1353153039303; Sat,
 17 Nov 2012 03:50:39 -0800 (PST)
Received: by 10.60.4.74 with HTTP; Sat, 17 Nov 2012 03:50:39 -0800 (PST)
In-Reply-To: <1353150353-29874-6-git-send-email-szeder@ira.uka.de>
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/209952>

On Sat, Nov 17, 2012 at 12:05 PM, SZEDER G=C3=A1bor <szeder@ira.uka.de>=
 wrote:

>  __gitcomp_nl ()
>  {
>         local IFS=3D$'\n'
> -       COMPREPLY=3D($(compgen -P "${2-}" -S "${4- }" -W "$1" -- "${3=
-$cur}"))
> +       COMPREPLY=3D($(awk -v pfx=3D"${2-}" -v sfx=3D"${4- }" -v cur=3D=
"${3-$cur}" '
> +               BEGIN {
> +                       FS=3D"\n";
> +                       len=3Dlength(cur);
> +               }
> +               {
> +                       if (cur =3D=3D substr($1, 1, len))
> +                               print pfx$1sfx;
> +               }' <<< "$1" ))
>  }

Does this really perform better than my alternative?

+       for x in $1; do
+               if [[ "$x" =3D "$3"* ]]; then
+                       COMPREPLY+=3D("$2$x$4")
+               fi
+       done

--=20
=46elipe Contreras