Re: [PATCH v2 02/11] tests: at-combinations: check ref names directly

[Felipe Contreras <felipe.contreras@gmail.com>]

On Wed, May 8, 2013 at 12:55 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> Some committishes might point to the same commit, but through a
>> different ref, that's why it's better to check directly for the ref,
>> rather than the commit message.
>>
>> We can do that by calling rev-parse --symbolic-full-name, and to
>> differentiate the old from the new behavior we add an extra argument to
>> the check() helper.
>>
>> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>> ---
>
> It is signed-off by Ram first but who is the author?  You, or him?

I am, but he sent the patch first.

>>  t/t1508-at-combinations.sh | 27 ++++++++++++++++-----------
>>  1 file changed, 16 insertions(+), 11 deletions(-)
>>
>> diff --git a/t/t1508-at-combinations.sh b/t/t1508-at-combinations.sh
>> index 46e3f16..bd2d2fe 100755
>> --- a/t/t1508-at-combinations.sh
>> +++ b/t/t1508-at-combinations.sh
>> @@ -4,9 +4,14 @@ test_description='test various @{X} syntax combinations together'
>>  . ./test-lib.sh
>>
>>  check() {
>> -test_expect_${3:-success} "$1 = $2" "
>> -     echo '$2' >expect &&
>> -     git log -1 --format=%s '$1' >actual &&
>> +test_expect_${4:-success} "$1 = $3" "
>> +     if [ '$2' == 'commit' ]; then
>> +             echo '$3' >expect &&
>> +             git log -1 --format=%s '$1' >actual
>> +     else
>> +             echo '$3' >expect &&
>> +             git rev-parse --symbolic-full-name '$1' >actual
>> +     fi &&
>
> Move the echo outside of if, and match the overall style.

Right.

-- 
Felipe Contreras