Re: [PATCH 3/3] t: mailmap: add simple name translation test

[Felipe Contreras <felipe.contreras@gmail.com>]

On Sun, Feb 5, 2012 at 8:17 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Felipe Contreras wrote:
>
>> You mean the commit message, you haven't made any comment about the code.
>
> No, for this patch, more important than the absence of any explanation
> in the commit message (which is also important) is the code change
> that seems unnecessarily invasive.

It only seems that way if you are not familiar with the code, and you
assume the worst.

Feel free propose an alternative change. You would find there's no
better way to simplify those changes.

Here's a tip: look at the previous change "CTO <cto@company.xx>", and
see how it's right next to each an every of the hunks introduced in
this patch.

> You've already demonstrated that I do not have the right communication
> style to explain such things to you and work towards a fix that
> addresses both our concerns.  So I give up.

You are assuming your concerns are valid without actually looking at the code.

> I'll just give my
> feedback on patches that concern code I care about and an explanation
> for the sake of others on the list that are better able to interact
> with you.  I am willing to work with or answer questions from anyone
> including you, though.

Your feedback is most certainly welcome, but you shouldn't assume you
are always right. There's nothing wrong with disagreeing, and in this
case I most definitely disagree, and there's nothing wrong with that.

-- 
Felipe Contreras