From: Felipe Contreras <felipe.contreras@gmail.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/9] t1508 (at-combinations): test branches separately
Date: Thu, 2 May 2013 12:30:37 -0500 [thread overview]
Message-ID: <CAMP44s1wv4sCQM6V3S2+56KnxPJVQAp1skiUP+vSEetmenB_+A@mail.gmail.com> (raw)
In-Reply-To: <CALkWK0=_zcO8K75YxmQVp9hog0yHJ_vH5QKRwpWN8QMUc2zm_Q@mail.gmail.com>
On Thu, May 2, 2013 at 12:28 PM, Ramkumar Ramachandra
<artagnon@gmail.com> wrote:
> Felipe Contreras wrote:
>> I'm not sure about this. If we introduce a check that fails, we would
>> have to do:
>>
>> check HEAD refs/heads/new-branch "" failure
>>
>> Which doesn't seem clean. Perhaps it makes more sense to always add
>> the type of check:
>>
>> check HEAD ref refs/heads/new-branch
>
> I think you misunderstood. Failure looks like this:
>
> check "@@{u}" ref refs/heads/upstream-branch failure
>
> And corresponding success like this:
>
> check "@@{u}" refs/heads/upstream-branch
>
> We can make the "ref" compulsory if you like. I thought about it too.
I think it's less surprising.
--
Felipe Contreras
next prev parent reply other threads:[~2013-05-02 17:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 13:39 [PATCH v2 0/9] A natural solution to the @ -> HEAD problem Ramkumar Ramachandra
2013-05-02 13:39 ` [PATCH 1/9] t1508 (at-combinations): simplify setup Ramkumar Ramachandra
2013-05-02 13:39 ` [PATCH 2/9] t1508 (at-combinations): test branches separately Ramkumar Ramachandra
2013-05-02 17:23 ` Felipe Contreras
2013-05-02 17:28 ` Ramkumar Ramachandra
2013-05-02 17:30 ` Felipe Contreras [this message]
2013-05-02 13:39 ` [PATCH 3/9] t1508 (at-combinations): improve nonsense() Ramkumar Ramachandra
2013-05-02 13:39 ` [PATCH 4/9] t1508 (at-combinations): increase coverage Ramkumar Ramachandra
2013-05-02 14:26 ` Eric Sunshine
2013-05-02 13:39 ` [PATCH 5/9] t1508 (at-combinations): document @{N} versus HEAD@{N} Ramkumar Ramachandra
2013-05-02 17:27 ` Felipe Contreras
2013-05-02 17:30 ` Ramkumar Ramachandra
2013-05-02 17:34 ` Felipe Contreras
2013-05-02 17:38 ` Ramkumar Ramachandra
2013-05-02 13:39 ` [PATCH 6/9] t1508 (at-combinations): test with symbolic refs Ramkumar Ramachandra
2013-05-02 13:39 ` [PATCH 7/9] remote.c: teach branch_get() to treat symrefs other than HEAD Ramkumar Ramachandra
2013-05-02 14:37 ` Ramkumar Ramachandra
2013-05-02 15:43 ` Ramkumar Ramachandra
2013-05-02 16:57 ` Felipe Contreras
2013-05-02 13:39 ` [PATCH 8/9] sha1_name.c: fix @-parsing bug in interpret_branch_name() Ramkumar Ramachandra
2013-05-02 13:39 ` [PATCH 9/9] refs.c: make @ a pseudo-ref alias to HEAD Ramkumar Ramachandra
2013-05-02 17:18 ` [PATCH v2 0/9] A natural solution to the @ -> HEAD problem Ramkumar Ramachandra
2013-05-02 17:25 ` Felipe Contreras
2013-05-02 17:34 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMP44s1wv4sCQM6V3S2+56KnxPJVQAp1skiUP+vSEetmenB_+A@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).