From: Felipe Contreras <felipe.contreras@gmail.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Git List <git@vger.kernel.org>,
Matthieu Moy <matthieu.moy@imag.fr>,
Ramkumar Ramachandra <artagnon@gmail.com>
Subject: Re: [PATCH 2/6] Add concept of 'publish' branch
Date: Sun, 1 Sep 2013 06:20:18 -0500 [thread overview]
Message-ID: <CAMP44s1x=7k3XTPSzHFk4gtJBY301mVbsQWammsp3HpdSzp2CA@mail.gmail.com> (raw)
In-Reply-To: <CAPig+cQUiSC4r01nSqRnrDj230x=tUK4dGUXhWrUitSAVKZ-Wg@mail.gmail.com>
On Sun, Sep 1, 2013 at 3:41 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Sun, Sep 1, 2013 at 4:26 AM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
>> +static void setup_push_simple(struct remote *remote, struct branch *branch,
>> + int triangular)
>> +{
>> + if (branch->push_name) {
>> + struct strbuf refspec = STRBUF_INIT;
>> + strbuf_addf(&refspec, "%s:%s", branch->name, branch->push_name);
>> + add_refspec(refspec.buf);
>
> strbuf_release(&refspec);
Actually no, wee need that buffer. See setup_push_upstream().
--
Felipe Contreras
next prev parent reply other threads:[~2013-09-01 11:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-01 8:26 [PATCH 0/6] Introduce publish tracking branch Felipe Contreras
2013-09-01 8:26 ` [PATCH 1/6] push: trivial reorganization Felipe Contreras
2013-09-01 8:26 ` [PATCH 2/6] Add concept of 'publish' branch Felipe Contreras
2013-09-01 8:41 ` Eric Sunshine
2013-09-01 11:20 ` Felipe Contreras [this message]
2013-09-01 8:26 ` [PATCH 3/6] branch: allow configuring the publish branch Felipe Contreras
2013-09-01 8:26 ` [PATCH 4/6] t: branch add publish branch tests Felipe Contreras
2013-09-01 8:26 ` [PATCH 5/6] push: add --set-publish option Felipe Contreras
2013-09-01 8:26 ` [PATCH 6/6] branch: display publish branch Felipe Contreras
2013-09-02 7:25 ` [PATCH 0/6] Introduce publish tracking branch Matthieu Moy
2013-09-02 7:38 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMP44s1x=7k3XTPSzHFk4gtJBY301mVbsQWammsp3HpdSzp2CA@mail.gmail.com' \
--to=felipe.contreras@gmail.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=matthieu.moy@imag.fr \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).