Re: [PATCH] remote-bzr: update old organization

[Felipe Contreras <felipe.contreras@gmail.com>]

On Fri, May 17, 2013 at 12:09 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> On Fri, May 17, 2013 at 5:02 AM, Sandor Bodo-Merle <sbodomerle@gmail.com> wrote:
>>
>>> apparently this breaks my existing clone of the bugzilla repository, where i
>>> have branches cloned with versions of remote-bzr prior 1.8.2 and after. The
>>> erro iget is:
>>>
>>> Fetching origin
>>> Traceback (most recent call last):
>>>   File "/home/bms/bin/git-remote-bzr", line 956, in <module>
>>>     sys.exit(main(sys.argv))
>>>   File "/home/bms/bin/git-remote-bzr", line 928, in main
>>>     repo = get_repo(url, alias)
>>>   File "/home/bms/bin/git-remote-bzr", line 844, in get_repo
>>>     bdir.destroy_repository()
>>>   File "/usr/lib/python2.7/dist-packages/bzrlib/bzrdir.py", line 900, in
>>> destroy_repository
>>>     raise errors.NoRepositoryPresent(self)
>>> bzrlib.errors.NoRepositoryPresent: No repository present:
>>> "file:///home/bms/workspace/bugzilla/.git/bzr/origin/clone/"
>>> error: Could not fetch origin
>>>
>>>
>>> The following small patch seems to fix my regression:
>>
>> The patch is fine by me, in fact, I already had that patch, but
>> somehow could not trigger the exception, so I removed it.
>
> Is it merely "fine", or needed for 1.8.3?  I am guessing it is the
> latter but making a final double-check, as I'll be stopping to pick
> up patches from the list in order to start today's integration run
> (that includes tagging 1.8.3-rc3).

Yes, for v1.8.3.

-- 
Felipe Contreras