From: Felipe Contreras <felipe.contreras@gmail.com>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: ">" <git@vger.kernel.org>, Jeff King <peff@peff.net>,
Junio C Hamano <gitster@pobox.com>,
Jonathan Nieder <jrnieder@gmail.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH v2 4/4] fast-export: make sure refs are updated properly
Date: Tue, 30 Oct 2012 23:56:20 +0100 [thread overview]
Message-ID: <CAMP44s2fgB=ruuVBdG6QjF6yviQAxVWFyhN6Vh3DWMGgmOKzyQ@mail.gmail.com> (raw)
In-Reply-To: <CAGdFq_iiGpYW-txPaa6mZrxg3mYdOX-Ez9uLF-rB5bAjZd5rWg@mail.gmail.com>
On Tue, Oct 30, 2012 at 11:35 PM, Sverre Rabbelier <srabbelier@gmail.com> wrote:
> On Tue, Oct 30, 2012 at 3:18 PM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
>> Which is expected and correct; the branch already points to the right
>> commit, no need for an extra reset.
>
> I think you're correct. Thanks for confirming.
Thanks for reviewing. If you are still not convinced, I could pull the
patches from msysgit and simplify them, I'm sure the end result would
be pretty similar, if not exactly the same as this patch (plus other
orthogonal changes). I saw some patches that were not part of the
patch series you sent before, so maybe that's why you expected certain
behavior that wasn't actually there in that particular patch series.
But hopefully that's not needed.
Cheers.
--
Felipe Contreras
next prev parent reply other threads:[~2012-10-30 22:56 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1351617089-13036-1-git-send-email-felipe.contreras@gmail.com>
[not found] ` <1351617089-13036-5-git-send-email-felipe.contreras@gmail.com>
2012-10-30 18:12 ` [PATCH v2 4/4] fast-export: make sure refs are updated properly Sverre Rabbelier
2012-10-30 18:47 ` Felipe Contreras
2012-10-30 21:17 ` Sverre Rabbelier
2012-10-30 21:35 ` Felipe Contreras
2012-10-30 21:38 ` Jonathan Nieder
2012-10-30 21:41 ` Felipe Contreras
2012-10-30 21:59 ` Sverre Rabbelier
2012-10-30 22:18 ` Felipe Contreras
2012-10-30 22:35 ` Sverre Rabbelier
2012-10-30 22:56 ` Felipe Contreras [this message]
[not found] ` <1351617089-13036-2-git-send-email-felipe.contreras@gmail.com>
2012-10-30 18:55 ` [PATCH v2 1/4] fast-export: trivial cleanup Jonathan Nieder
[not found] ` <1351617089-13036-3-git-send-email-felipe.contreras@gmail.com>
2012-10-30 18:57 ` [PATCH v2 2/4] fast-export: fix comparisson in tests Jonathan Nieder
[not found] ` <1351617089-13036-4-git-send-email-felipe.contreras@gmail.com>
2012-10-30 18:59 ` [PATCH v2 3/4] fast-export: don't handle uninteresting refs Jonathan Nieder
2012-10-30 19:17 ` Felipe Contreras
2012-10-30 21:40 ` Felipe Contreras
2012-10-30 21:45 ` Jonathan Nieder
2012-10-30 22:01 ` Felipe Contreras
2012-10-30 22:07 ` Jonathan Nieder
2012-10-30 22:22 ` Felipe Contreras
2012-10-30 23:55 ` Jonathan Nieder
2012-10-31 1:03 ` Felipe Contreras
2012-10-31 1:08 ` Jonathan Nieder
2012-10-31 1:39 ` Felipe Contreras
2012-10-31 1:51 ` Jonathan Nieder
2012-10-31 2:22 ` Felipe Contreras
2012-10-31 0:57 ` Jonathan Nieder
2012-10-31 1:23 ` Felipe Contreras
2012-10-31 1:35 ` Jonathan Nieder
[not found] ` <20121030184755.GC15167@elie.Belkin>
[not found] ` <CAMP44s2F3qJeGL4V5KZjFNqKA5hrFQKRxXMrakFA6pTNi1DZ3w@mail.gmail.com>
[not found] ` <20121030190126.GJ15167@elie.Belkin>
[not found] ` <CAMP44s1W4mwK+cNwBqu2S0=Aw04XX9KBan8w4ghyzqbODdmiLQ@mail.gmail.com>
2012-10-30 19:41 ` Johannes Schindelin
2012-10-30 19:06 [PATCH v3 0/4] fast-export: general fixes Felipe Contreras
2012-10-30 19:06 ` [PATCH v3 4/4] fast-export: make sure refs are updated properly Felipe Contreras
2012-10-31 0:11 ` [PATCH v2 " Jonathan Nieder
2012-10-31 2:08 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMP44s2fgB=ruuVBdG6QjF6yviQAxVWFyhN6Vh3DWMGgmOKzyQ@mail.gmail.com' \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=jrnieder@gmail.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).