From: Felipe Contreras <felipe.contreras@gmail.com>
To: John Keeping <john@keeping.me.uk>
Cc: git@vger.kernel.org,
Florian Achleitner <florian.achleitner.2.6.31@gmail.com>,
Sverre Rabbelier <srabbelier@gmail.com>
Subject: Re: [PATCH] gitremote-helpers(1): clarify refspec behaviour
Date: Wed, 17 Apr 2013 17:30:33 -0500 [thread overview]
Message-ID: <CAMP44s38Cqcr4mwDBexW4tHzv3BKffCYEn5oN0U6Wji10nmJMw@mail.gmail.com> (raw)
In-Reply-To: <505914600ac7f4afc26f8b29fbece26156c87519.1365272021.git.john@keeping.me.uk>
On Sat, Apr 6, 2013 at 12:13 PM, John Keeping <john@keeping.me.uk> wrote:
> --- a/Documentation/gitremote-helpers.txt
> +++ b/Documentation/gitremote-helpers.txt
> @@ -174,8 +174,8 @@ ref.
> This capability can be advertised multiple times. The first
> applicable refspec takes precedence. The left-hand of refspecs
> advertised with this capability must cover all refs reported by
> -the list command. If no 'refspec' capability is advertised,
> -there is an implied `refspec *:*`.
> +the list command. If a helper does not need a specific 'refspec'
> +capability then it should advertise `refspec *:*`.
But if it advertises a straight 'refspec *:*', nothing would work. If
anything, it should be 'refs/heads/*:refs/remotes/$alias/*', but then
tags would fail. Why not just tell the remote helpers to do the right
thing and avoid this comment altogether?
--
Felipe Contreras
prev parent reply other threads:[~2013-04-17 22:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-06 18:13 [PATCH] gitremote-helpers(1): clarify refspec behaviour John Keeping
2013-04-06 18:15 ` Sverre Rabbelier
2013-04-17 22:30 ` Felipe Contreras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMP44s38Cqcr4mwDBexW4tHzv3BKffCYEn5oN0U6Wji10nmJMw@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=florian.achleitner.2.6.31@gmail.com \
--cc=git@vger.kernel.org \
--cc=john@keeping.me.uk \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).