From: Felipe Contreras <felipe.contreras@gmail.com>
To: Stefan Haller <lists@haller-berlin.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Alexey via GitGitGadget <gitgitgadget@gmail.com>,
Git <git@vger.kernel.org>, Alexey <lesha.ogonkov@gmail.com>
Subject: Re: [PATCH] Fix zsh installation instructions
Date: Sat, 24 Oct 2020 22:29:14 -0500 [thread overview]
Message-ID: <CAMP44s3=CUmx_7DCExK7L4trZvQTxO67Qk20eexsP3su-3RyKQ@mail.gmail.com> (raw)
In-Reply-To: <abc4ab95-ed65-1d6b-e964-73734c08cda9@haller-berlin.de>
On Wed, Oct 14, 2020 at 12:39 PM Stefan Haller <lists@haller-berlin.de> wrote:
> Yes, the change is sane. The wrong file extension (.zsh vs. .bash) was a
> documentation bug that I had noticed myself, but forgot to submit a
> patch for.
Yes, a patch was wrongly applied that changed it from .sh to .zsh.
> The other hunk (adding compinit) is not so important to me; I suppose it
> was not in the original version because most zsh users already have this
> in their .zshrc anyway. But it's not wrong, and doesn't hurt to have
> here, I guess.
If you don't have compinit, then how is the '_git' script being loaded
in the first place?
--
Felipe Contreras
next prev parent reply other threads:[~2020-10-25 3:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 10:51 [PATCH] Fix zsh installation instructions Alexey via GitGitGadget
2020-07-06 22:42 ` Junio C Hamano
2020-10-14 15:10 ` Stefan Haller
2020-10-16 17:06 ` Junio C Hamano
2020-10-25 3:29 ` Felipe Contreras [this message]
2020-10-27 8:29 ` Stefan Haller
2020-10-27 8:32 ` Stefan Haller
2020-10-27 8:59 ` Лёша Огоньков
2020-10-27 20:00 ` Junio C Hamano
2020-10-28 1:45 ` Felipe Contreras
2020-10-29 17:50 ` Junio C Hamano
2020-10-29 19:09 ` Junio C Hamano
2020-11-02 20:49 ` Felipe Contreras
2020-11-02 20:54 ` Felipe Contreras
2020-11-03 1:02 ` Junio C Hamano
2020-11-02 22:37 ` Junio C Hamano
2020-10-28 1:31 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMP44s3=CUmx_7DCExK7L4trZvQTxO67Qk20eexsP3su-3RyKQ@mail.gmail.com' \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=lesha.ogonkov@gmail.com \
--cc=lists@haller-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).