git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Antoine Pelisse <apelisse@gmail.com>,
	Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH v2 2/3] fast-export: improve speed by skipping blobs
Date: Mon, 6 May 2013 14:15:52 -0500	[thread overview]
Message-ID: <CAMP44s3N53fHswhayqGehTJAP0huJqRup73jxYuiv7sVYUnN_g@mail.gmail.com> (raw)
In-Reply-To: <20130506191146.GA3056@sigill.intra.peff.net>

On Mon, May 6, 2013 at 2:11 PM, Jeff King <peff@peff.net> wrote:
> On Mon, May 06, 2013 at 02:02:13PM -0500, Felipe Contreras wrote:
>
>> > I did a double-take on reading this subject line and first paragraph,
>> > thinking "surely fast-export needs to actually output blobs?".
>>
>> If you think that, then you are not familiar with the code.
>>
>> --export-marks=<file>::
>> [...]
>
> My point was that nothing in the subject line nor that first paragraph
> (nor, for that matter, the entire commit message) says that we are
> talking about marks here.

s/$/ while loading marks/. Fixed.

-- 
Felipe Contreras

  reply	other threads:[~2013-05-06 19:16 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-05 22:38 [PATCH v2 0/3] fast-export: speed improvements Felipe Contreras
2013-05-05 22:38 ` [PATCH v2 1/3] fast-{import,export}: use get_sha1_hex() directly Felipe Contreras
2013-05-07 14:38   ` Junio C Hamano
2013-05-07 22:13     ` Felipe Contreras
2013-05-07 23:19       ` Junio C Hamano
2013-05-05 22:38 ` [PATCH v2 2/3] fast-export: improve speed by skipping blobs Felipe Contreras
2013-05-06 12:31   ` Jeff King
2013-05-06 15:08     ` Junio C Hamano
2013-05-06 16:17       ` Junio C Hamano
2013-05-06 16:20       ` Jeff King
2013-05-06 16:32         ` Junio C Hamano
2013-05-06 16:40           ` Jeff King
2013-05-06 17:17             ` Junio C Hamano
2013-05-06 17:19               ` Jeff King
2013-05-06 17:41                 ` Jeff King
2013-05-06 19:12         ` Felipe Contreras
2013-05-06 19:09       ` Felipe Contreras
2013-05-06 20:58         ` Junio C Hamano
2013-05-06 21:30           ` Felipe Contreras
2013-05-07  1:59             ` Junio C Hamano
2013-05-07  3:49               ` Felipe Contreras
2013-05-06 19:02     ` Felipe Contreras
2013-05-06 19:11       ` Jeff King
2013-05-06 19:15         ` Felipe Contreras [this message]
2013-05-05 22:38 ` [PATCH v2 3/3] fast-export: don't parse all the commits Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMP44s3N53fHswhayqGehTJAP0huJqRup73jxYuiv7sVYUnN_g@mail.gmail.com \
    --to=felipe.contreras@gmail.com \
    --cc=apelisse@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johannes.schindelin@gmx.de \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).