From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "SZEDER Gábor" <szeder@ira.uka.de>,
git@vger.kernel.org,
"Carsten Mattner" <carstenmattner@googlemail.com>,
"Jeff King" <peff@peff.net>
Subject: Re: [PATCH 1/2] completion: rename _git and _gitk
Date: Tue, 22 May 2012 20:52:32 +0200 [thread overview]
Message-ID: <CAMP44s3yErr97pFy=izy3ydKd=xwPH+ar89mwJeu9pP7SOxgig@mail.gmail.com> (raw)
In-Reply-To: <7vsjes3xl9.fsf@alter.siamese.dyndns.org>
On Tue, May 22, 2012 at 8:00 PM, Junio C Hamano <gitster@pobox.com> wrote:
> SZEDER Gábor <szeder@ira.uka.de> writes:
>
>>> -_git ()
>>> +_main_git ()
>>
>>> -_gitk ()
>>> +_main_gitk ()
>>
>> After all those namespace discussions the names of these functions
>> should start with _git or __git.
>
> As these are pure implementation internal details that are called from
> very limited places, I do not think Felipe minds a patch to update them.
I don't mind updating these to whatever you decide is the namespace
for internal functions, just avoid _git ().
Cheers.
--
Felipe Contreras
next prev parent reply other threads:[~2012-05-22 18:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-19 2:41 [PATCH 0/2] completion: backwards compatibility fix Felipe Contreras
2012-05-19 2:41 ` [PATCH 1/2] completion: rename _git and _gitk Felipe Contreras
2012-05-22 8:24 ` SZEDER Gábor
2012-05-22 18:00 ` Junio C Hamano
2012-05-22 18:52 ` Felipe Contreras [this message]
2012-05-19 2:41 ` [PATCH 2/2] completion: add support for backwards compatibility Felipe Contreras
2012-05-19 2:45 ` [PATCH 0/2] completion: backwards compatibility fix Jeff King
2012-05-19 7:54 ` Carsten Mattner
2012-05-19 15:31 ` Jeff King
2012-05-19 17:45 ` Carsten Mattner
2012-05-20 5:11 ` Junio C Hamano
2012-05-20 9:02 ` Carsten Mattner
2012-05-20 10:28 ` Felipe Contreras
2012-05-20 17:27 ` Carsten Mattner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMP44s3yErr97pFy=izy3ydKd=xwPH+ar89mwJeu9pP7SOxgig@mail.gmail.com' \
--to=felipe.contreras@gmail.com \
--cc=carstenmattner@googlemail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).