git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brandon Turner <bt@brandonturner.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] completion: ignore chpwd_functions when cding
Date: Wed, 8 Oct 2014 16:50:16 -0500	[thread overview]
Message-ID: <CAMUzdXkQcbwhmJRYog+X_9B_cdWv6FkTrVFT__Dsw2k+qKN0=g@mail.gmail.com> (raw)
In-Reply-To: <xmqqh9zebfc6.fsf@gitster.dls.corp.google.com>

On Wed, Oct 8, 2014 at 1:12 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
>
> Can you mention that this is abomination limited only to zsh
> somewhere in the log message?  Or does bash share the same glitch?
>
> If this is limited to zsh, I wonder if we can take advantage of the
> fact that we have git-completion.bash and git-completion.zsh to
> avoid contaminating shared part of the code.

I'm going to submit two versions of the patch:
v2 - addresses the log message, but the patch still applies to bash
and zsh
v3 - moves the change to git-completion.zsh as an override, bash is
unaffected

>From my testing, bash is unaffected, so v3 would be an ok fix.  Since
we cannot control what functions users add to chpwd_functions, v2 might
make more sense.

      parent reply	other threads:[~2014-10-08 21:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-08  3:53 [PATCH] completion: ignore chpwd_functions when cding Brandon Turner
2014-10-08 18:12 ` Junio C Hamano
2014-10-08 21:49   ` [PATCH v2] " Brandon Turner
2014-10-08 21:49   ` [PATCH v3] completion: ignore chpwd_functions when cding on zsh Brandon Turner
2014-10-09  7:34     ` Øystein Walle
2014-10-09 18:10       ` Junio C Hamano
2014-10-09 19:01         ` [PATCH v4] " Brandon Turner
2014-10-09 19:47           ` Øystein Walle
2014-10-09 20:01             ` Junio C Hamano
2014-10-09 20:45           ` Junio C Hamano
2014-10-09 22:04             ` Brandon Turner
2014-10-09 22:11               ` Junio C Hamano
2014-10-09 22:30                 ` Brandon Turner
2014-10-16 18:10                   ` Øystein Walle
2014-10-09 19:21         ` [PATCH v3] " Øystein Walle
2014-10-08 21:50   ` Brandon Turner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMUzdXkQcbwhmJRYog+X_9B_cdWv6FkTrVFT__Dsw2k+qKN0=g@mail.gmail.com' \
    --to=bt@brandonturner.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).