From: Jack Nagel <jacknagel@gmail.com>
To: git@vger.kernel.org
Subject: Combining APPLE_COMMON_CRYPTO=1 and NO_OPENSSL=1 produces unexpected result
Date: Wed, 25 Nov 2015 10:10:44 -0500 [thread overview]
Message-ID: <CAMYxyaVQyVRQb-b0nVv412tMZ3rEnOfUPRakg2dEREg5_Ba5Ag@mail.gmail.com> (raw)
When compiling git on OS X (where APPLE_COMMON_CRYPTO=1 is the
default) and specifying NO_OPENSSL=1, the resulting git uses the
BLK_SHA1 implementation rather than the functions available in
CommonCrypto.
$ uname -a
Darwin broadwell.local 15.0.0 Darwin Kernel Version 15.0.0: Sat Sep 19
15:53:46 PDT 2015; root:xnu-3247.10.11~1/RELEASE_X86_64 x86_64
$ make NO_OPENSSL=1
[...]
$ nm git | grep _SHA1_
0000000100173f00 t _blk_SHA1_Block
0000000100174e80 T _blk_SHA1_Final
000000010018fbb0 s _blk_SHA1_Final.pad
0000000100173de0 T _blk_SHA1_Init
0000000100173e10 T _blk_SHA1_Update
However, with OpenSSL available, it does use the CommonCrypto functions:
$ make
[...]
$ nm git | grep _SHA1_
U _CC_SHA1_Final
U _CC_SHA1_Init
U _CC_SHA1_Update
I would not expect the presence of NO_OPENSSL=1 to change the behavior
here, since neither case actually makes use of the OpenSSL SHA1
functions.
next reply other threads:[~2015-11-25 15:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 15:10 Jack Nagel [this message]
2015-12-23 8:51 ` Combining APPLE_COMMON_CRYPTO=1 and NO_OPENSSL=1 produces unexpected result Eric Sunshine
2015-12-28 2:29 ` Junio C Hamano
2016-01-02 23:49 ` David Aguilar
2016-01-15 18:52 ` Junio C Hamano
2016-01-15 20:28 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMYxyaVQyVRQb-b0nVv412tMZ3rEnOfUPRakg2dEREg5_Ba5Ag@mail.gmail.com \
--to=jacknagel@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).