From: Joanna Wang <jojwang@google.com>
To: gitster@pobox.com
Cc: git@vger.kernel.org, Joanna Wang <jojwang@chromium.org>
Subject: Re: Supporting `git add -a <exclude submodules>`
Date: Tue, 17 Oct 2023 16:59:30 -0400 [thread overview]
Message-ID: <CAMmZTi-xOWxpzL1SvErgri0_gwvED5Vu2NfeGVcW7jCN8gyEDQ@mail.gmail.com> (raw)
> choose among attr:submodule, attr:type=<what>, attr:bits=<permbits>, decide what keyword to use
Whatever we choose, do we want to block these keywords from being used
by folks in their .gitattributes files?
That would break any existing usage of the keywords. Is this a concern?
Option A: To keep things working, we could add this support for attr,
but then always prioritize whatever is set in .gitattributes. So this
new behavior would only be triggered if the keywords (e.g.
"submodule", "type", "bits") aren't set in .gitattributes (or w/e list
of attributes are being read).
Option B: Or we could add this new behavior for `attr-bits:<permbits>`
or just `bits:<permbits>`.
I personally don't see big UX differences between A and B. Any opinions on this?
next reply other threads:[~2023-10-17 20:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 20:59 Joanna Wang [this message]
2023-10-17 21:36 ` Supporting `git add -a <exclude submodules>` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2023-10-17 22:48 Joanna Wang
2023-10-17 23:02 ` Junio C Hamano
2023-09-28 17:06 Joanna Wang
2023-09-28 18:11 ` Junio C Hamano
2023-09-28 18:16 ` Junio C Hamano
2023-09-28 18:24 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMmZTi-xOWxpzL1SvErgri0_gwvED5Vu2NfeGVcW7jCN8gyEDQ@mail.gmail.com \
--to=jojwang@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jojwang@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).