From: "erik elfström" <erik.elfstrom@gmail.com>
To: Thomas Gummerer <t.gummerer@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH/RFC v3 0/4] Improving performance of git clean
Date: Tue, 21 Apr 2015 20:21:37 +0200 [thread overview]
Message-ID: <CAMpP7NaUv10Ox0gNsE8cg4hUnNNiFi8NZSLw6F6SW+SLrt0VwQ@mail.gmail.com> (raw)
In-Reply-To: <20150420221414.GA13813@hank>
Ok, thanks for looking into this.
I have no well founded opinions on the implementation but I do
think the performance tests would be more meaningful if the
setup/cleanup code could be removed from the timed section.
If the community agrees on an implementation I would be happy
to convert the new tests, either directly in this series or as a follow
up if that is preferred.
/Erik
On Tue, Apr 21, 2015 at 12:14 AM, Thomas Gummerer <t.gummerer@gmail.com> wrote:
> On 04/18, Erik Elfström wrote:
>> * Still have issues in the performance tests, see comments
>> from Thomas Gummerer on v2
>
> I've looked at the "modern" style tests again, and I don't the code
> churn is worth it just for using them for the performance tests. If
> anyone wants to take a look at the code, it's at
> github.com/tgummerer/git tg/perf-lib.
>
> I think adding the test_perf_setup_cleanup command would make more
> sense in this case. If you want I can send a patch for that.
next prev parent reply other threads:[~2015-04-21 18:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-18 20:41 [PATCH/RFC v3 0/4] Improving performance of git clean Erik Elfström
2015-04-18 20:41 ` [PATCH/RFC v3 1/4] setup: add gentle version of read_gitfile Erik Elfström
2015-04-18 20:41 ` [PATCH/RFC v3 2/4] t7300: add tests to document behavior of clean and nested git Erik Elfström
2015-04-18 20:41 ` [PATCH/RFC v3 3/4] p7300: add performance tests for clean Erik Elfström
2015-04-18 20:41 ` [PATCH/RFC v3 4/4] clean: improve performance when removing lots of directories Erik Elfström
2015-04-19 1:14 ` [PATCH/RFC v3 0/4] Improving performance of git clean Junio C Hamano
2015-04-21 18:17 ` erik elfström
2015-04-20 22:14 ` Thomas Gummerer
2015-04-21 18:21 ` erik elfström [this message]
2015-04-21 19:02 ` Junio C Hamano
2015-04-21 21:24 ` Jeff King
2015-04-22 19:30 ` erik elfström
2015-04-22 19:46 ` Jeff King
2015-04-22 19:53 ` erik elfström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMpP7NaUv10Ox0gNsE8cg4hUnNNiFi8NZSLw6F6SW+SLrt0VwQ@mail.gmail.com \
--to=erik.elfstrom@gmail.com \
--cc=git@vger.kernel.org \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).