From: "erik elfström" <erik.elfstrom@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Thomas Gummerer <t.gummerer@gmail.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH/RFC v3 0/4] Improving performance of git clean
Date: Wed, 22 Apr 2015 21:30:20 +0200 [thread overview]
Message-ID: <CAMpP7NbruKC97L1ROXV0Up9Fks8FJmgB_nxTTWpSHp-8VVE+Xw@mail.gmail.com> (raw)
In-Reply-To: <20150421212427.GB13230@peff.net>
On Tue, Apr 21, 2015 at 11:24 PM, Jeff King <peff@peff.net> wrote:
>
> If I understand correctly, the reason that you need per-run setup is
> that your "git clean" command actually cleans things, and you need to
> restore the original state for each time-trial. Can you instead use "git
> clean -n" to do a dry-run? I think what you are timing is really the
> "figure out what to clean" step, and not the cleaning itself.
>
> -Peff
Yes, that is the problem. A dry run will spot this particular performance
issue but maybe we lose some value as a general performance test if
we only do "half" the clean? Admittedly we clearly lose some value in
the current state as well due to the copying taking more time than the
cleaning. I could go either way here.
/Erik
next prev parent reply other threads:[~2015-04-22 19:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-18 20:41 [PATCH/RFC v3 0/4] Improving performance of git clean Erik Elfström
2015-04-18 20:41 ` [PATCH/RFC v3 1/4] setup: add gentle version of read_gitfile Erik Elfström
2015-04-18 20:41 ` [PATCH/RFC v3 2/4] t7300: add tests to document behavior of clean and nested git Erik Elfström
2015-04-18 20:41 ` [PATCH/RFC v3 3/4] p7300: add performance tests for clean Erik Elfström
2015-04-18 20:41 ` [PATCH/RFC v3 4/4] clean: improve performance when removing lots of directories Erik Elfström
2015-04-19 1:14 ` [PATCH/RFC v3 0/4] Improving performance of git clean Junio C Hamano
2015-04-21 18:17 ` erik elfström
2015-04-20 22:14 ` Thomas Gummerer
2015-04-21 18:21 ` erik elfström
2015-04-21 19:02 ` Junio C Hamano
2015-04-21 21:24 ` Jeff King
2015-04-22 19:30 ` erik elfström [this message]
2015-04-22 19:46 ` Jeff King
2015-04-22 19:53 ` erik elfström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMpP7NbruKC97L1ROXV0Up9Fks8FJmgB_nxTTWpSHp-8VVE+Xw@mail.gmail.com \
--to=erik.elfstrom@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).