From: "Rémi Rampin" <remirampin@gmail.com>
To: git@vger.kernel.org
Subject: [git-gui] bug report: "Open existing repository" dialog fails on submodules
Date: Fri, 30 Jan 2015 16:46:08 -0500 [thread overview]
Message-ID: <CAMto89Dvz-u+at4CPLGQRak4niOJk1trSCn2wQugLUnD1h=Fjw@mail.gmail.com> (raw)
Hi,
This bug report concerns git-gui. Apologies if this is not the right
mailing-list.
By submodule I mean a repository for which .git is not a regular Git
directory, but rather a "gitdir: ..." file.
While running "git gui" from such a directory will work fine, trying
to open it from the choose_repository window will fail with "Not a Git
repository". This is because of the simplistic implementation of proc
_is_git in lib/choose_repository.tcl.
I suggest fixing that function, or using Git directly to perform that
check, for instance checking "git rev-parse --show-toplevel". I'd
attempt a patch but my tcl-fu is weak.
Best
--
Rémi Rampin
next reply other threads:[~2015-01-30 21:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 21:46 Rémi Rampin [this message]
2015-02-02 8:41 ` [git-gui] bug report: "Open existing repository" dialog fails on submodules Chris Packham
2015-02-02 8:43 ` Chris Packham
2015-02-02 15:59 ` Rémi Rampin
2015-02-02 17:24 ` [PATCH 1/2] Fixes _is_git Remi Rampin
2015-02-02 17:24 ` [PATCH 2/2] Makes _do_open2 set _gitdir to actual path Remi Rampin
2015-02-03 8:51 ` Chris Packham
2015-02-03 16:00 ` Rémi Rampin
2015-02-03 8:44 ` [PATCH 1/2] Fixes _is_git Chris Packham
2015-02-03 15:52 ` Rémi Rampin
2015-02-05 8:13 ` Chris Packham
2015-02-05 16:20 ` [PATCH 0/2] gitfile support git git-gui Remi Rampin
2015-02-05 16:20 ` [PATCH 1/2] Fixes chooser not accepting gitfiles Remi Rampin
2015-02-05 16:20 ` [PATCH 2/2] Makes chooser set 'gitdir' to the resolved path Remi Rampin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMto89Dvz-u+at4CPLGQRak4niOJk1trSCn2wQugLUnD1h=Fjw@mail.gmail.com' \
--to=remirampin@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).