Re: [PATCH 0/6] Fix misuses of "nor"

[Justin Lebar <jlebar@google.com>]

> I guess I'm cc'd because I made a few of those or/nor mistakes.

I actually didn't look that closely at the blame; I cc'ed you because
you were a top contributor in a few of the directories I was touching.

> I suggest that you merge "Fix misuses of "nor" outside comments"
> and "Tests: Fix muses of "nor"" into one. Otherwise you break the test
> suite at 5/6

Sure thing, will do.

There's a similar incompatibility with the l10n change and "Fix
misuses of "nor" outside comments": The former references strings
changed in the latter.  Should I merge these, or should I enforce a
particular ordering between these patches?  (Right now the l10n patch
comes before the string changes in the code, but that's probably wrong
now that I think about it.)

> Being a non-native English speaker I'm not really qualified to review this.

FWIW even being a native English speaker I was unsure about a few of
the changes myself.  This caused me to finally break down and order
Garner's Modern American Usage, which I hope will reveal all.  :)

-Justin

On Sat, Mar 15, 2014 at 1:56 AM, Duy Nguyen <pclouds@gmail.com> wrote:
> On Sat, Mar 15, 2014 at 3:41 PM, Justin Lebar <jlebar@google.com> wrote:
>> I got annoyed by git's awkward use of "nor" in man pages and in git add -p, so
>> I went ahead and audited all uses of "nor" in the tree.  One might be able to
>> argue that some of the uses I've changed are technically acceptable, but that's
>> a pretty low bar to set for ourselves.  I aimed to make everything both correct
>> and idiomatic.
>
> I guess I'm cc'd because I made a few of those or/nor mistakes. Being
> a non-native English speaker I'm not really qualified to review this.
> But I suggest that you merge "Fix misuses of "nor" outside comments"
> and "Tests: Fix muses of "nor"" into one. Otherwise you break the test
> suite at 5/6 (and 6/6 fixes it, but breaking the test suite at any
> commit is not very bisect-friendly).
> --
> Duy