From: "Martin Ågren" <martin.agren@gmail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>,
"Martin Ågren" <martin.agren@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>,
"Emily Shaffer" <emilyshaffer@google.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Shourya Shukla" <shouryashukla.oo@gmail.com>
Subject: Re: [PATCH v2] docs: add a FAQ
Date: Wed, 25 Mar 2020 19:03:45 +0100 [thread overview]
Message-ID: <CAN0heSomisiFsO-_bkGYFgj0nS5yZy9ewU883APDiMK5Sw=srg@mail.gmail.com> (raw)
In-Reply-To: <20200325110328.GK6499@camp.crustytoothpaste.net>
On Wed, 25 Mar 2020 at 12:03, brian m. carlson
<sandals@crustytoothpaste.net> wrote:
>
> On 2020-03-25 at 06:23:49, Martin Ågren wrote:
> > On Wed, 25 Mar 2020 at 02:37, brian m. carlson
> > I read this as:
> >
> > How do I prevent users from making "certain changes with hooks"?
> >
> > As opposed to your intended meaning:
> >
> > How do I (with hooks) prevent users from making certain changes?
> >
> > I'm not suggesting the latter as a "fix" for this "problem" though,
> > since it's a bit clumsy. How about adding a comma:
> >
> > How do I prevent users from making certain changes, with hooks?
> >
> > Or maybe just dropping those last two words.
> >
> > Please trust your judgement on whether this is a problem, and if so, how
> > to go about addressing it -- I know you have lots of such judgement.
>
> How about, "How do I use hooks to prevent users from making certain
> changes?" That seems to both read smoothly and avoid the misplaced
> modifier.
Very nice.
Martin
next prev parent reply other threads:[~2020-03-25 18:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 1:34 [PATCH v2 0/1] FAQ for common user questions brian m. carlson
2020-03-25 1:34 ` [PATCH v2] docs: add a FAQ brian m. carlson
2020-03-25 6:23 ` Martin Ågren
2020-03-25 11:03 ` brian m. carlson
2020-03-25 18:03 ` Martin Ågren [this message]
2020-03-25 6:10 ` [PATCH v2 0/1] FAQ for common user questions Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN0heSomisiFsO-_bkGYFgj0nS5yZy9ewU883APDiMK5Sw=srg@mail.gmail.com' \
--to=martin.agren@gmail.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sandals@crustytoothpaste.net \
--cc=shouryashukla.oo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).