From: "Martin Ågren" <martin.agren@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Phillip Wood <phillip.wood123@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH v2 0/2] stash: fix and improve "git stash -p <pathspec>"
Date: Fri, 6 Jun 2025 13:39:31 +0200 [thread overview]
Message-ID: <CAN0heSpRWoiPh-c9y27unLgx18VNiHwJvnPiUERM_KSiP-39=g@mail.gmail.com> (raw)
In-Reply-To: <xmqqcybkh3wg.fsf@gitster.g>
On Wed, 4 Jun 2025 at 00:11, Junio C Hamano <gitster@pobox.com> wrote:
>
> > Phillip Wood (2):
> > stash: allow "git stash -p <pathspec>" to assume push again
> > stash: allow "git stash [<options>] --patch <pathspec>" to assume push
>
> Are other people interested in this work? I haven't seen any
> comments other than a few nitpicky one form mine, and want to (1)
> gauge the interest in the fix, and (2) see how well reviewed it is
> (and my review or reading over the patches again would not count all
> that much here).
On reading the patches, I realized that I have some interest in this. I
left some comments. Most of them amount to thinking out loud, but I do
think that the new test could do a bit better at proving that the
(fixed/improved) implementation actually ends up picking up `-p` at all.
A nice, pleasant read. The series has a well-defined focus.
Martin
next prev parent reply other threads:[~2025-06-06 11:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 14:58 [PATCH] stash: allow "git stash -p <pathspec>" to assume push again Phillip Wood
2025-05-16 19:10 ` Junio C Hamano
2025-05-20 9:21 ` Phillip Wood
2025-05-20 9:26 ` [PATCH v2 0/2] stash: fix and improve "git stash -p <pathspec>" Phillip Wood
2025-05-20 9:26 ` [PATCH v2 1/2] stash: allow "git stash -p <pathspec>" to assume push again Phillip Wood
2025-06-06 11:31 ` Martin Ågren
2025-06-06 15:26 ` Phillip Wood
2025-05-20 9:27 ` [PATCH v2 2/2] stash: allow "git stash [<options>] --patch <pathspec>" to assume push Phillip Wood
2025-06-06 11:32 ` Martin Ågren
2025-05-21 13:04 ` [PATCH v2 0/2] stash: fix and improve "git stash -p <pathspec>" Junio C Hamano
2025-06-03 22:11 ` Junio C Hamano
2025-06-06 11:39 ` Martin Ågren [this message]
2025-06-07 9:45 ` [PATCH v3 " Phillip Wood
2025-06-07 9:45 ` [PATCH v3 1/2] stash: allow "git stash -p <pathspec>" to assume push again Phillip Wood
2025-06-07 9:45 ` [PATCH v3 2/2] stash: allow "git stash [<options>] --patch <pathspec>" to assume push Phillip Wood
2025-06-07 12:56 ` [PATCH v3 0/2] stash: fix and improve "git stash -p <pathspec>" Martin Ågren
2025-06-09 9:42 ` Phillip Wood
2025-06-10 9:56 ` Martin Ågren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN0heSpRWoiPh-c9y27unLgx18VNiHwJvnPiUERM_KSiP-39=g@mail.gmail.com' \
--to=martin.agren@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).