From: "Martin Ågren" <martin.agren@gmail.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
"brian m . carlson" <sandals@crustytoothpaste.net>,
Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH v2 0/4] rename "sha1-foo" files
Date: Thu, 31 Dec 2020 14:36:01 +0100 [thread overview]
Message-ID: <CAN0heSrRpfP5XLHAvAkFnoydudwNJU4tGZr88DNwd9VAekrugg@mail.gmail.com> (raw)
In-Reply-To: <0223aa36-7071-a37c-a188-c45a43d76b4f@gmail.com>
On Thu, 31 Dec 2020 at 13:48, Derrick Stolee <stolee@gmail.com> wrote:
>
> On 12/31/2020 6:56 AM, Martin Ågren wrote:
> > "SHA-1" (capital letters). So this v2 is a bit bigger than v1, but not
> > by too much, I think. The range-diff is below.
>
> Makes sense. Thanks for being diligent!
> This range-diff looks sensible. I approve v2.
>
> Reviewed-by: Derrick Stolee <dstolee@microsoft.com>
Thanks, Stolee!
Martin
prev parent reply other threads:[~2020-12-31 13:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 23:52 [PATCH 0/4] rename "sha1-foo" files Martin Ågren
2020-12-29 23:52 ` [PATCH 1/4] object-name.c: rename from sha1-name.c Martin Ågren
2020-12-30 1:19 ` Derrick Stolee
2020-12-29 23:52 ` [PATCH 2/4] object-file.c: rename from sha1-file.c Martin Ågren
2020-12-29 23:52 ` [PATCH 3/4] sha1-lookup: rename `sha1_pos()` as `hash_pos()` Martin Ågren
2020-12-30 1:21 ` Derrick Stolee
2020-12-29 23:53 ` [PATCH 4/4] hash-lookup: rename from sha1-lookup Martin Ågren
2020-12-30 1:29 ` [PATCH 0/4] rename "sha1-foo" files Derrick Stolee
2020-12-30 8:01 ` Martin Ågren
2020-12-30 13:35 ` Derrick Stolee
2020-12-30 4:22 ` brian m. carlson
2020-12-30 8:04 ` Martin Ågren
2020-12-31 11:56 ` [PATCH v2 " Martin Ågren
2020-12-31 11:56 ` [PATCH v2 1/4] object-name.c: rename from sha1-name.c Martin Ågren
2020-12-31 11:56 ` [PATCH v2 2/4] object-file.c: rename from sha1-file.c Martin Ågren
2020-12-31 11:56 ` [PATCH v2 3/4] sha1-lookup: rename `sha1_pos()` as `hash_pos()` Martin Ågren
2020-12-31 11:56 ` [PATCH v2 4/4] hash-lookup: rename from sha1-lookup Martin Ågren
2020-12-31 12:47 ` [PATCH v2 0/4] rename "sha1-foo" files Derrick Stolee
2020-12-31 13:36 ` Martin Ågren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN0heSrRpfP5XLHAvAkFnoydudwNJU4tGZr88DNwd9VAekrugg@mail.gmail.com \
--to=martin.agren@gmail.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).