From: "Martin Ågren" <martin.agren@gmail.com>
To: "Rubén Justo" <rjusto@gmail.com>
Cc: git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH] ref-filter.c: fix a leak in get_head_description
Date: Mon, 26 Sep 2022 08:59:34 +0200 [thread overview]
Message-ID: <CAN0heSra_LsBzYCNFh0cZOZ0pmk1Wb9RtNTLwi93UM=f-53Uxw@mail.gmail.com> (raw)
In-Reply-To: <6ff29e96-7f8d-c354-dced-b1b363e54467@gmail.com>
On Sun, 25 Sept 2022 at 00:53, Rubén Justo <rjusto@gmail.com> wrote:
>
> In 2708ce62d2 (branch: sort detached HEAD based on a flag, 2021-01-07) a
> call to wt_status_state_free_buffers, responsible of freeing the
> resources that could be allocated in the local struct wt_status_state
> state, was eliminated.
>
> The call to wt_status_state_free_buffers was introduced in 962dd7ebc3
> (wt-status: introduce wt_status_state_free_buffers(), 2020-09-27). This
> commit brings back that call in get_head_description.
> + wt_status_state_free_buffers(&state);
> +
> return strbuf_detach(&desc, NULL);
> }
Good catch, and excellent history digging. From the original submission
[1] of the patch that dropped this call, I get the feeling that it was
originally developed some time earlier. I suspect this call was then
accidentally dropped in a rebase before submission.
FWIW, this patch is
Reviewed-by: Martin Ågren <martin.agren@gmail.com>
[1] https://lore.kernel.org/git/20210106100139.14651-1-avarab@gmail.com/
Martin
next prev parent reply other threads:[~2022-09-26 6:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-24 22:53 [PATCH] ref-filter.c: fix a leak in get_head_description Rubén Justo
2022-09-26 6:59 ` Martin Ågren [this message]
2022-09-26 19:12 ` Junio C Hamano
2022-09-27 5:59 ` Martin Ågren
2022-09-26 8:14 ` Ævar Arnfjörð Bjarmason
2022-09-26 19:13 ` Rubén Justo
2022-10-08 0:35 ` [PATCH v2] wt-status: using of wt_status_state_free_buffers Rubén Justo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN0heSra_LsBzYCNFh0cZOZ0pmk1Wb9RtNTLwi93UM=f-53Uxw@mail.gmail.com' \
--to=martin.agren@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=rjusto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).