From: "Martin Ågren" <martin.agren@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 13/13] parse_opt_ref_sorting: always use with NONEG flag
Date: Wed, 20 Mar 2019 13:22:22 +0100 [thread overview]
Message-ID: <CAN0heSrubOaXRbg=NBi0rCuzthUcOEU3HmUKGg+=t+N0CCJcbA@mail.gmail.com> (raw)
In-Reply-To: <20190320081650.GM10403@sigill.intra.peff.net>
On Wed, 20 Mar 2019 at 09:17, Jeff King <peff@peff.net> wrote:
> - since this was cut-and-pasted to four different spots, let's define
> a single OPT_REF_SORT() macro that we can use everywhere
Indeed, all four are identical. And FWIW I failed to find a fifth caller
anywhere (I looked for "OPT_CALLBACK.*sort").
> - OPT_CALLBACK(0 , "sort", sorting_tail, N_("key"),
> - N_("field name to sort on"), &parse_opt_ref_sorting),
> + OPT_REF_SORT(sorting_tail),
> +#define OPT_REF_SORT(var) \
> + OPT_CALLBACK_F(0, "sort", (var), \
> + N_("key"), N_("field name to sort"), \
> + PARSE_OPT_NONEG, parse_opt_ref_sorting)
This one is not identical though. ;-) You drop the "on". I trust you to
know which of these is (more) correct, but I was a bit surprised to see
"on" disappear without any mention. Mistake, or intended?
Other than that surprise ending, the whole series was a nice read.
Martin
next prev parent reply other threads:[~2019-03-20 12:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 8:12 [PATCH 0/13] more unused parameter cleanups Jeff King
2019-03-20 8:13 ` [PATCH 01/13] revision: drop some unused "revs" parameters Jeff King
2019-03-20 8:13 ` [PATCH 02/13] log: drop unused rev_info from early output Jeff King
2019-03-20 8:14 ` [PATCH 03/13] log: drop unused "len" from show_tagger() Jeff King
2019-03-20 8:14 ` [PATCH 04/13] update-index: drop unused prefix_length parameter from do_reupdate() Jeff King
2019-03-20 8:14 ` [PATCH 05/13] test-date: drop unused "now" parameter from parse_dates() Jeff King
2019-03-20 8:15 ` [PATCH 06/13] unpack-trees: drop name_entry from traverse_by_cache_tree() Jeff King
2019-03-20 8:15 ` [PATCH 07/13] unpack-trees: drop unused error_type parameters Jeff King
2019-03-20 8:15 ` [PATCH 08/13] report_path_error(): drop unused prefix parameter Jeff King
2019-03-20 8:16 ` [PATCH 09/13] fetch_pack(): drop unused parameters Jeff King
2019-03-20 8:16 ` [PATCH 10/13] parse-options: drop unused ctx parameter from show_gitcomp() Jeff King
2019-03-20 8:16 ` [PATCH 11/13] pretty: drop unused "type" parameter in needs_rfc2047_encoding() Jeff King
2019-03-20 8:16 ` [PATCH 12/13] pretty: drop unused strbuf from parse_padding_placeholder() Jeff King
2019-03-20 8:16 ` [PATCH 13/13] parse_opt_ref_sorting: always use with NONEG flag Jeff King
2019-03-20 12:22 ` Martin Ågren [this message]
2019-03-20 20:22 ` Jeff King
2019-03-20 9:29 ` [PATCH 0/13] more unused parameter cleanups Junio C Hamano
2019-03-21 8:50 ` Ævar Arnfjörð Bjarmason
2019-03-21 9:44 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN0heSrubOaXRbg=NBi0rCuzthUcOEU3HmUKGg+=t+N0CCJcbA@mail.gmail.com' \
--to=martin.agren@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).