From: Nipunn Koorapati <nipunn1313@gmail.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Nipunn Koorapati via GitGitGadget <gitgitgadget@gmail.com>,
Git List <git@vger.kernel.org>,
Nipunn Koorapati <nipunn@dropbox.com>
Subject: Re: [PATCH 2/3] fsmonitor: add assertion that fsmonitor is valid to check_removed
Date: Mon, 15 Mar 2021 15:01:37 -0700 [thread overview]
Message-ID: <CAN8Z4-VFekryNYczJBkFQpkLJngcHJ5JBH0tb5ObNsrc241uSw@mail.gmail.com> (raw)
In-Reply-To: <CAPig+cT9aAPGzysqAz2OBrZP-7Ci+h+W5wFgnRm8bsde9K6zdw@mail.gmail.com>
> Unusual 4-space indentation rather than typical 1-tab.
Thanks for identifying - will fix in the next patch series. Perhaps in
a separate patch we could add a unit test that validates the codebase
for such style?
next prev parent reply other threads:[~2021-03-15 22:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-14 22:17 [PATCH 0/3] teach git to respect fsmonitor in diff-index Nipunn Koorapati via GitGitGadget
2021-03-14 22:17 ` [PATCH 1/3] fsmonitor: skip lstat deletion check during git diff-index Nipunn Koorapati via GitGitGadget
2021-03-14 22:17 ` [PATCH 2/3] fsmonitor: add assertion that fsmonitor is valid to check_removed Nipunn Koorapati via GitGitGadget
2021-03-14 22:35 ` Eric Sunshine
2021-03-15 22:01 ` Nipunn Koorapati [this message]
2021-03-15 22:51 ` Eric Sunshine
2021-03-14 22:17 ` [PATCH 3/3] fsmonitor: add perf test for git diff HEAD Nipunn Koorapati via GitGitGadget
2021-03-17 21:22 ` [PATCH v2 0/3] teach git to respect fsmonitor in diff-index Nipunn Koorapati via GitGitGadget
2021-03-17 21:22 ` [PATCH v2 1/3] fsmonitor: skip lstat deletion check during git diff-index Nipunn Koorapati via GitGitGadget
2021-03-18 20:44 ` Junio C Hamano
2021-03-18 21:36 ` Nipunn Koorapati
2021-03-17 21:22 ` [PATCH v2 2/3] fsmonitor: add assertion that fsmonitor is valid to check_removed Nipunn Koorapati via GitGitGadget
2021-03-18 20:47 ` Junio C Hamano
2021-03-18 22:57 ` Nipunn Koorapati
2021-03-17 21:22 ` [PATCH v2 3/3] fsmonitor: add perf test for git diff HEAD Nipunn Koorapati via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN8Z4-VFekryNYczJBkFQpkLJngcHJ5JBH0tb5ObNsrc241uSw@mail.gmail.com \
--to=nipunn1313@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=nipunn@dropbox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).